From: Yangtao Li <tiny.windzz@gmail.com>
To: jassisinghbrar@gmail.com, nsaenzjulienne@suse.de,
f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com,
bcm-kernel-feedback-list@broadcom.com, lftan@altera.com,
matthias.bgg@gmail.com, agross@kernel.org,
bjorn.andersson@linaro.org, mcoquelin.stm32@gmail.com,
alexandre.torgue@st.com, thierry.reding@gmail.com,
jonathanh@nvidia.com, linux-kernel@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
nios2-dev@lists.rocketboards.org,
linux-mediatek@lists.infradead.org,
linux-arm-msm@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-tegra@vger.kernel.org
Cc: Yangtao Li <tiny.windzz@gmail.com>
Subject: [PATCH 12/13] mailbox: omap: do some cleanup
Date: Sat, 28 Dec 2019 18:35:37 +0000 [thread overview]
Message-ID: <20191228183538.26189-12-tiny.windzz@gmail.com> (raw)
In-Reply-To: <20191228183538.26189-1-tiny.windzz@gmail.com>
Use devm_platform_ioremap_resource() to simplify code.
'i' and 'ret' are variables of the same type and there is no
need to use two lines.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
drivers/mailbox/omap-mailbox.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/mailbox/omap-mailbox.c b/drivers/mailbox/omap-mailbox.c
index 5978a35aac6d..9b9994be5602 100644
--- a/drivers/mailbox/omap-mailbox.c
+++ b/drivers/mailbox/omap-mailbox.c
@@ -695,8 +695,7 @@ static struct mbox_chan *omap_mbox_of_xlate(struct mbox_controller *controller,
static int omap_mbox_probe(struct platform_device *pdev)
{
- struct resource *mem;
- int ret;
+ int ret, i;
struct mbox_chan *chnls;
struct omap_mbox **list, *mbox, *mboxblk;
struct omap_mbox_fifo_info *finfo, *finfoblk;
@@ -709,7 +708,6 @@ static int omap_mbox_probe(struct platform_device *pdev)
u32 num_users, num_fifos;
u32 tmp[3];
u32 l;
- int i;
if (!node) {
pr_err("%s: only DT-based devices are supported\n", __func__);
@@ -772,8 +770,7 @@ static int omap_mbox_probe(struct platform_device *pdev)
if (!mdev)
return -ENOMEM;
- mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- mdev->mbox_base = devm_ioremap_resource(&pdev->dev, mem);
+ mdev->mbox_base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(mdev->mbox_base))
return PTR_ERR(mdev->mbox_base);
--
2.17.1
next prev parent reply other threads:[~2019-12-28 18:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-28 18:35 [PATCH 01/13] mailbox: altera: convert to devm_platform_ioremap_resource Yangtao Li
2019-12-28 18:35 ` [PATCH 02/13] mailbox: xgene-slimpro: do some cleanup Yangtao Li
2019-12-28 18:35 ` [PATCH 03/13] mailbox: qcom-apcs: convert to devm_platform_ioremap_resource Yangtao Li
2019-12-29 1:59 ` Bjorn Andersson
2019-12-28 18:35 ` [PATCH 04/13] mailbox: mediatek: cmdq: " Yangtao Li
2019-12-30 1:58 ` CK Hu
2019-12-28 18:35 ` [PATCH 05/13] mailbox: bcm2835: " Yangtao Li
2020-01-07 10:57 ` Nicolas Saenz Julienne
2019-12-28 18:35 ` [PATCH 06/13] mailbox: hi3660: " Yangtao Li
2019-12-30 1:04 ` Leo Yan
2019-12-28 18:35 ` [PATCH 07/13] mailbox: platform-mhu: " Yangtao Li
2019-12-28 18:35 ` [PATCH 08/13] mailbox: stm32-ipcc: " Yangtao Li
2019-12-28 18:35 ` [PATCH 09/13] mailbox: sti: do some cleanup Yangtao Li
2019-12-28 18:35 ` [PATCH 10/13] mailbox: tegra: convert to devm_platform_ioremap_resource Yangtao Li
2019-12-28 18:35 ` [PATCH 11/13] mailbox: hi6220: " Yangtao Li
2019-12-28 18:35 ` Yangtao Li [this message]
2019-12-28 18:35 ` [PATCH 13/13] mailbox: armada-37xx-rwtm: " Yangtao Li
2020-01-08 9:43 ` Gregory CLEMENT
2019-12-30 1:50 ` [PATCH 01/13] mailbox: altera: " Tan, Ley Foon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191228183538.26189-12-tiny.windzz@gmail.com \
--to=tiny.windzz@gmail.com \
--cc=agross@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bjorn.andersson@linaro.org \
--cc=f.fainelli@gmail.com \
--cc=jassisinghbrar@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=lftan@altera.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-tegra@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=nios2-dev@lists.rocketboards.org \
--cc=nsaenzjulienne@suse.de \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).