From: Faiz Abbas <faiz_abbas@ti.com>
To: <linux-kernel@vger.kernel.org>, <linux-mmc@vger.kernel.org>
Cc: <ulf.hansson@linaro.org>, <adrian.hunter@intel.com>,
<faiz_abbas@ti.com>, <shawn.lin@rock-chips.com>
Subject: [PATCH 1/3] mmc: sdhci: Add Quirk to reset data lines after tuning
Date: Mon, 30 Dec 2019 14:53:41 +0530 [thread overview]
Message-ID: <20191230092343.30692-2-faiz_abbas@ti.com> (raw)
In-Reply-To: <20191230092343.30692-1-faiz_abbas@ti.com>
Some arasan controllers have data leftover in the buffer after tuning
procedure is complete which interferes with future data commands. Add a
quirk to reset the data after tuning is finished.
Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
---
drivers/mmc/host/sdhci.c | 3 +++
drivers/mmc/host/sdhci.h | 4 ++++
2 files changed, 7 insertions(+)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 1b1c26da3fe0..e4b478efb560 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -2316,6 +2316,9 @@ EXPORT_SYMBOL_GPL(sdhci_start_tuning);
void sdhci_end_tuning(struct sdhci_host *host)
{
+ if (host->quirks2 & SDHCI_QUIRK2_RESET_DATA_POST_TUNING)
+ sdhci_reset(host, SDHCI_RESET_DATA);
+
sdhci_writel(host, host->ier, SDHCI_INT_ENABLE);
sdhci_writel(host, host->ier, SDHCI_SIGNAL_ENABLE);
}
diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
index fe83ece6965b..28826124f7c3 100644
--- a/drivers/mmc/host/sdhci.h
+++ b/drivers/mmc/host/sdhci.h
@@ -484,6 +484,10 @@ struct sdhci_host {
* block count.
*/
#define SDHCI_QUIRK2_USE_32BIT_BLK_CNT (1<<18)
+/*
+ * Controller needs to reset data lines once tuning is complete
+ */
+#define SDHCI_QUIRK2_RESET_DATA_POST_TUNING (1<<19)
int irq; /* Device IRQ */
void __iomem *ioaddr; /* Mapped address */
--
2.19.2
next prev parent reply other threads:[~2019-12-30 9:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-30 9:23 [PATCH 0/3] Fix issues with command queuing in arasan controllers Faiz Abbas
2019-12-30 9:23 ` Faiz Abbas [this message]
2019-12-30 9:23 ` [PATCH 2/3] mmc: sdhci_am654: Enable Quirk to reset data after tuning Faiz Abbas
2019-12-30 9:23 ` [RFT PATCH 3/3] mmc: sdhci-of-arasan: Fix Command Queuing enable handling Faiz Abbas
2020-01-03 0:36 ` Shawn Lin
2020-01-08 11:30 ` [PATCH 0/3] Fix issues with command queuing in arasan controllers Faiz Abbas
2020-01-08 11:42 ` Adrian Hunter
2020-01-08 11:49 ` Faiz Abbas
2020-01-08 11:59 ` Adrian Hunter
2020-01-08 12:04 ` Faiz Abbas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191230092343.30692-2-faiz_abbas@ti.com \
--to=faiz_abbas@ti.com \
--cc=adrian.hunter@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).