From: Martin Kepplinger <martin.kepplinger@puri.sm>
To: Felipe Balbi <balbi@kernel.org>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: g_multi rmmod problem: usb_put_function_instance(fi_acm) hangs
Date: Mon, 13 Jan 2020 16:16:15 +0100 [thread overview]
Message-ID: <fa9a267f-bd74-0512-f0c6-99a28fbfa0ed@puri.sm> (raw)
hi,
on the librem5 with defconfig
https://source.puri.sm/martin.kepplinger/linux-next/blob/next-20200110/librem5_cpuidle_mainline_atf/arch/arm64/configs/librem5_defconfig
running next-20200110 I load g_multi during startup.
rmmod g_multi results in error like
[ 190.995685] dwc3 38100000.usb: timed out waiting for SETUP phase
or
[ 109.702545] dwc3 38100000.usb: failed to enable ep0out
and hangs rmmod. What "fixes" the problem is the following change below.
Does that make any sense to you?
How would a real fix look like here, or how would I further debug?
thanks,
martin
--- a/drivers/usb/gadget/legacy/multi.c
+++ b/drivers/usb/gadget/legacy/multi.c
@@ -459,7 +459,8 @@ static int multi_unbind(struct usb_composite_dev *cdev)
#ifdef USB_ETH_RNDIS
usb_put_function(f_acm_rndis);
#endif
- usb_put_function_instance(fi_acm);
+ /* FIXME the following hangs during rmmod */
+ // usb_put_function_instance(fi_acm);
#ifdef USB_ETH_RNDIS
usb_put_function(f_rndis);
usb_put_function_instance(fi_rndis);
reply other threads:[~2020-01-13 15:16 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa9a267f-bd74-0512-f0c6-99a28fbfa0ed@puri.sm \
--to=martin.kepplinger@puri.sm \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).