From: Andreas Kemnade <andreas@kemnade.info>
To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de,
pmeerw@pmeerw.net, lee.jones@linaro.org, b.galvani@gmail.com,
linus.walleij@linaro.org, andreas@kemnade.info,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
phh@phh.me, stefan@agner.ch, letux-kernel@openphoenux.org
Subject: [RFC PATCH 5/5] mfd: rn5t618: add ADC subdevice for RN5T618
Date: Fri, 17 Jan 2020 22:59:26 +0100 [thread overview]
Message-ID: <20200117215926.15194-6-andreas@kemnade.info> (raw)
In-Reply-To: <20200117215926.15194-1-andreas@kemnade.info>
RN5T618 has an ADC but RN5T567 has not, so
we need separate subdevice lists for both.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
Untested, IMHO only acceptable with a Tested-By
drivers/mfd/rn5t618.c | 26 ++++++++++++++++++++++++--
1 file changed, 24 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/rn5t618.c b/drivers/mfd/rn5t618.c
index 6828fd40b0a1..d37d7a31cf26 100644
--- a/drivers/mfd/rn5t618.c
+++ b/drivers/mfd/rn5t618.c
@@ -21,6 +21,7 @@
static const struct mfd_cell rn5t618_cells[] = {
{ .name = "rn5t618-regulator" },
{ .name = "rn5t618-wdt" },
+ { .name = "rn5t618-adc" },
};
static const struct mfd_cell rc5t619_cells[] = {
@@ -30,6 +31,11 @@ static const struct mfd_cell rc5t619_cells[] = {
{ .name = "rn5t618-wdt" },
};
+static const struct mfd_cell rn5t567_cells[] = {
+ { .name = "rn5t618-regulator" },
+ { .name = "rn5t618-wdt" },
+};
+
static bool rn5t618_volatile_reg(struct device *dev, unsigned int reg)
{
switch (reg) {
@@ -203,16 +209,32 @@ static int rn5t618_i2c_probe(struct i2c_client *i2c,
return ret;
}
- if (priv->variant == RC5T619)
+ switch (priv->variant) {
+ case RC5T619:
ret = devm_mfd_add_devices(&i2c->dev, PLATFORM_DEVID_NONE,
rc5t619_cells,
ARRAY_SIZE(rc5t619_cells),
NULL, 0, NULL);
- else
+ break;
+ case RN5T618:
ret = devm_mfd_add_devices(&i2c->dev, PLATFORM_DEVID_NONE,
rn5t618_cells,
ARRAY_SIZE(rn5t618_cells),
NULL, 0, NULL);
+ break;
+ case RN5T567:
+ ret = devm_mfd_add_devices(&i2c->dev, PLATFORM_DEVID_NONE,
+ rn5t567_cells,
+ ARRAY_SIZE(rn5t567_cells),
+ NULL, 0, NULL);
+ break;
+ /*
+ * Should not happen because we come here only with a valid device
+ * tree match, so variant contains any of the above.
+ */
+ default:
+ return -ENOENT;
+ }
if (ret) {
dev_err(&i2c->dev, "failed to add sub-devices: %d\n", ret);
return ret;
--
2.20.1
prev parent reply other threads:[~2020-01-17 22:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 21:59 [PATCH 0/5] mfd: rn5t618: add ADC support Andreas Kemnade
2020-01-17 21:59 ` [PATCH 1/5] mfd: rn5t618: mark ADC control register volatile Andreas Kemnade
2020-01-20 8:49 ` Lee Jones
2020-01-17 21:59 ` [PATCH 2/5] mfd: rn5t618: add ADC subdevice for RC5T619 Andreas Kemnade
2020-01-20 8:49 ` Lee Jones
2020-01-24 15:28 ` Andreas Kemnade
2020-01-27 9:28 ` Lee Jones
2020-01-27 11:15 ` Andreas Kemnade
2020-01-17 21:59 ` [PATCH 3/5] iio: adc: rn5t618: Add ADC driver for RN5T618/RC5T619 Andreas Kemnade
2020-01-18 14:53 ` Jonathan Cameron
2020-01-18 22:14 ` Andreas Kemnade
2020-01-17 21:59 ` [RFC PATCH 4/5] mfd: rn5t618: add IRQ definitions for RN5T618 Andreas Kemnade
2020-01-17 21:59 ` Andreas Kemnade [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200117215926.15194-6-andreas@kemnade.info \
--to=andreas@kemnade.info \
--cc=b.galvani@gmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=letux-kernel@openphoenux.org \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phh@phh.me \
--cc=pmeerw@pmeerw.net \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).