From: "Adam J. Richter" <adam@yggdrasil.com>
To: viro@math.psu.edu
Cc: linux-kernel@vger.kernel.org
Subject: Trivial patch: linux-2.5.50/fs/read_write.c contained unnecessary assignment in do_readv_writev
Date: Sat, 30 Nov 2002 11:43:05 -0800 [thread overview]
Message-ID: <20021130114305.A503@baldur.yggdrasil.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 807 bytes --]
Hi Al,
I'm not sure if you are the right person to send this
to. If there is a more appropriate person to send this patch
to, feel free to redirect me.
The following patch deletes an unncessary assignment
in do_readv_writev. I've widened the patch context to make it
clear that the assignment was being overwritten immediately,
regardless of the result of the "if" statement that follows it.
If this patch looks OK, can you please forward it to Linus?
If you'd rather I send this down some other path to Linus, please let
me know.
--
Adam J. Richter __ ______________ 575 Oroville Road
adam@yggdrasil.com \ / Milpitas, California 95035
+1 408 309-6081 | g g d r a s i l United States of America
"Free Software For The Rest Of Us."
[-- Attachment #2: diff --]
[-- Type: text/plain, Size: 543 bytes --]
--- linux-2.5.50/fs/read_write.c 2002-11-27 14:36:14.000000000 -0800
+++ linux/fs/read_write.c 2002-11-30 11:35:14.000000000 -0800
@@ -400,15 +400,14 @@
/* VERIFY_WRITE actually means a read, as we write to user space */
ret = locks_verify_area((type == READ
? FLOCK_VERIFY_READ : FLOCK_VERIFY_WRITE),
inode, file, *pos, tot_len);
if (ret)
goto out;
- fnv = NULL;
if (type == READ) {
fn = file->f_op->read;
fnv = file->f_op->readv;
} else {
fn = (io_fn_t)file->f_op->write;
fnv = file->f_op->writev;
}
reply other threads:[~2002-11-30 19:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021130114305.A503@baldur.yggdrasil.com \
--to=adam@yggdrasil.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).