From: John Garry <john.garry@huawei.com>
To: <jejb@linux.vnet.ibm.com>, <martin.petersen@oracle.com>
Cc: <linux-scsi@vger.kernel.org>, <linuxarm@huawei.com>,
<linux-kernel@vger.kernel.org>,
Luo Jiaxing <luojiaxing@huawei.com>,
"John Garry" <john.garry@huawei.com>
Subject: [PATCH 4/7] scsi: hisi_sas: Modify the file permissions of trigger_dump to write only
Date: Mon, 20 Jan 2020 20:22:34 +0800 [thread overview]
Message-ID: <1579522957-4393-5-git-send-email-john.garry@huawei.com> (raw)
In-Reply-To: <1579522957-4393-1-git-send-email-john.garry@huawei.com>
From: Luo Jiaxing <luojiaxing@huawei.com>
The trigger_dump file is only used to manually trigger the dump, and did
not provide a read callback function for it, so it's file permission
setting to 600 is wrong, and should be changed to 200.
Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com>
Signed-off-by: John Garry <john.garry@huawei.com>
---
drivers/scsi/hisi_sas/hisi_sas_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
index 3e103e86e964..61db3376b1f9 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_main.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
@@ -3930,7 +3930,7 @@ void hisi_sas_debugfs_init(struct hisi_hba *hisi_hba)
hisi_hba->debugfs_dir = debugfs_create_dir(dev_name(dev),
hisi_sas_debugfs_dir);
- debugfs_create_file("trigger_dump", 0600,
+ debugfs_create_file("trigger_dump", 0200,
hisi_hba->debugfs_dir,
hisi_hba,
&hisi_sas_debugfs_trigger_dump_fops);
--
2.17.1
next prev parent reply other threads:[~2020-01-20 12:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 12:22 [PATCH 0/7] hisi_sas: Misc patches John Garry
2020-01-20 12:22 ` [PATCH 1/7] scsi: hisi_sas: use threaded irq to process CQ interrupts John Garry
2020-01-20 12:22 ` [PATCH 2/7] scsi: hisi_sas: replace spin_lock_irqsave/spin_unlock_restore with spin_lock/spin_unlock John Garry
2020-01-20 12:22 ` [PATCH 3/7] scsi: hisi_sas: Replace magic number when handle channel interrupt John Garry
2020-01-20 12:22 ` John Garry [this message]
2020-01-20 12:22 ` [PATCH 5/7] scsi: hisi_sas: Add prints for v3 hw interrupt converge and automatic affinity John Garry
2020-01-20 12:22 ` [PATCH 6/7] scsi: hisi_sas: Rename hisi_sas_cq.pci_irq_mask John Garry
2020-01-20 12:22 ` [PATCH 7/7] scsi: hisi_sas: Use reply map for v2 hw John Garry
2020-01-21 0:31 ` [PATCH 0/7] hisi_sas: Misc patches Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1579522957-4393-5-git-send-email-john.garry@huawei.com \
--to=john.garry@huawei.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=luojiaxing@huawei.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).