linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@linux.intel.com>
To: linux-kernel@vger.kernel.org
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
	bp@alien8.de, peterz@infradead.org, luto@kernel.org,
	x86@kernel.org, torvalds@linux-foundation.org,
	akpm@linux-foundation.org
Subject: [PATCH 1/5] x86/alternatives: add missing insn.h include
Date: Thu, 23 Jan 2020 11:04:58 -0800	[thread overview]
Message-ID: <20200123190458.00285A85@viggo.jf.intel.com> (raw)
In-Reply-To: <20200123190456.8E05ADE6@viggo.jf.intel.com>


From: Dave Hansen <dave.hansen@linux.intel.com>

While testing my MPX removal series, Borislav noted compilation
failure with an allnoconfig build.

Turned out to be a missing include of insn.h in alternative.c.
With MPX, it got it implicitly from:

	asm/mmu_context.h -> asm/mpx.h -> asm/insn.h

Fixes: c3d6324f841b ("x86/alternatives: Teach text_poke_bp() to emulate instructions")
Reported-by: Borislav Petkov <bp@alien8.de>
Cc: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: x86@kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
---

 b/arch/x86/kernel/alternative.c |    1 +
 1 file changed, 1 insertion(+)

diff -puN arch/x86/kernel/alternative.c~x86-alternatives-include arch/x86/kernel/alternative.c
--- a/arch/x86/kernel/alternative.c~x86-alternatives-include	2020-01-23 10:41:03.811942442 -0800
+++ b/arch/x86/kernel/alternative.c	2020-01-23 10:41:03.815942442 -0800
@@ -23,6 +23,7 @@
 #include <asm/nmi.h>
 #include <asm/cacheflush.h>
 #include <asm/tlbflush.h>
+#include <asm/insn.h>
 #include <asm/io.h>
 #include <asm/fixmap.h>
 
_

  reply	other threads:[~2020-01-23 19:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-23 19:04 [PATCH 0/5] x86: finish the MPX removal process Dave Hansen
2020-01-23 19:04 ` Dave Hansen [this message]
2020-01-23 19:05 ` [PATCH 2/5] x86/mpx: remove build infrastructure Dave Hansen
2020-01-23 19:05 ` [PATCH 3/5] x86/mpx: remove bounds exception code Dave Hansen
2020-01-23 19:05 ` [PATCH 4/5] mm: remove arch_bprm_mm_init() hook Dave Hansen
2020-01-23 19:05 ` [PATCH 5/5] x86/mpx: remove MPX from arch/x86 Dave Hansen
2020-01-23 19:26 ` [PATCH 0/5] x86: finish the MPX removal process Linus Torvalds
2020-01-23 20:26   ` Borislav Petkov
2020-01-23 21:23     ` Dave Hansen
2020-01-24  0:01       ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200123190458.00285A85@viggo.jf.intel.com \
    --to=dave.hansen@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=bp@alien8.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=peterz@infradead.org \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).