From: Stephen Boyd <swboyd@chromium.org>
To: John Stultz <john.stultz@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>
Subject: [PATCH v3 4/4] alarmtimer: Update alarmtimer_get_rtcdev() docs to reflect reality
Date: Thu, 23 Jan 2020 21:58:49 -0800 [thread overview]
Message-ID: <20200124055849.154411-5-swboyd@chromium.org> (raw)
In-Reply-To: <20200124055849.154411-1-swboyd@chromium.org>
This function doesn't do anything like this comment says when an RTC
device hasn't been chosen. It looks like we used to do something like
that before commit 8bc0dafb5cf3 ("alarmtimers: Rework RTC device
selection using class interface") but that's long gone now. Remove this
sentence to avoid confusing the reader.
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
---
kernel/time/alarmtimer.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/kernel/time/alarmtimer.c b/kernel/time/alarmtimer.c
index 36124aea8d6f..2ffb466af77e 100644
--- a/kernel/time/alarmtimer.c
+++ b/kernel/time/alarmtimer.c
@@ -67,8 +67,6 @@ static DEFINE_SPINLOCK(rtcdev_lock);
* alarmtimer_get_rtcdev - Return selected rtcdevice
*
* This function returns the rtc device to use for wakealarms.
- * If one has not already been chosen, it checks to see if a
- * functional rtc device is available.
*/
struct rtc_device *alarmtimer_get_rtcdev(void)
{
--
Sent by a computer, using git, on the internet
next prev parent reply other threads:[~2020-01-24 5:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 5:58 [PATCH v3 0/4] Fix alarmtimer suspend failure Stephen Boyd
2020-01-24 5:58 ` [PATCH v3 1/4] alarmtimer: Make alarmtimer platform device child of RTC device Stephen Boyd
2020-01-24 20:08 ` [tip: timers/core] " tip-bot2 for Stephen Boyd
2020-01-24 5:58 ` [PATCH v3 2/4] alarmtimer: Use wakeup source from alarmtimer platform device Stephen Boyd
2020-01-24 20:08 ` [tip: timers/core] " tip-bot2 for Stephen Boyd
2020-01-24 5:58 ` [PATCH v3 3/4] alarmtimer: Make alarmtimer_get_rtcdev() a stub when CONFIG_RTC_CLASS=n Stephen Boyd
2020-01-24 20:08 ` [tip: timers/core] " tip-bot2 for Stephen Boyd
2020-01-24 5:58 ` Stephen Boyd [this message]
2020-01-24 20:08 ` [tip: timers/core] alarmtimer: Update alarmtimer_get_rtcdev() docs to reflect reality tip-bot2 for Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200124055849.154411-5-swboyd@chromium.org \
--to=swboyd@chromium.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).