From: Thara Gopinath <thara.gopinath@linaro.org>
To: mingo@redhat.com, peterz@infradead.org, ionela.voinescu@arm.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rui.zhang@intel.com, qperret@google.com,
daniel.lezcano@linaro.org, viresh.kumar@linaro.org,
rostedt@goodmis.org, will@kernel.org, catalin.marinas@arm.com,
sudeep.holla@arm.com, juri.lelli@redhat.com, corbet@lwn.net
Cc: linux-kernel@vger.kernel.org, amit.kachhap@gmail.com,
javi.merino@kernel.org, amit.kucheria@verdurent.com
Subject: [Patch v9 4/8] sched/fair: Enable periodic update of average thermal pressure
Date: Tue, 28 Jan 2020 17:36:03 -0500 [thread overview]
Message-ID: <1580250967-4386-5-git-send-email-thara.gopinath@linaro.org> (raw)
In-Reply-To: <1580250967-4386-1-git-send-email-thara.gopinath@linaro.org>
Introduce support in scheduler periodic tick and other CFS bookkeeping
apis to trigger the process of computing average thermal pressure for a
cpu. Also consider avg_thermal.load_avg in others_have_blocked which
allows for decay of pelt signals.
Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org>
---
v8->v9:
- Moved periodic triggering of thermal pressure averaging from CFS
tick function to generic scheduler core tick function.
kernel/sched/core.c | 3 +++
kernel/sched/fair.c | 5 +++++
2 files changed, 8 insertions(+)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index fc1dfc0..b921795 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -3594,12 +3594,15 @@ void scheduler_tick(void)
struct rq *rq = cpu_rq(cpu);
struct task_struct *curr = rq->curr;
struct rq_flags rf;
+ unsigned long thermal_pressure;
sched_clock_tick();
rq_lock(rq, &rf);
update_rq_clock(rq);
+ thermal_pressure = arch_cpu_thermal_pressure(cpu_of(rq));
+ update_thermal_load_avg(rq_clock_task(rq), rq, thermal_pressure);
curr->sched_class->task_tick(rq, curr, 0);
calc_global_load_tick(rq);
psi_task_tick(rq);
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index ebf5095..5f58c03 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -7491,6 +7491,9 @@ static inline bool others_have_blocked(struct rq *rq)
if (READ_ONCE(rq->avg_dl.util_avg))
return true;
+ if (thermal_load_avg(rq))
+ return true;
+
#ifdef CONFIG_HAVE_SCHED_AVG_IRQ
if (READ_ONCE(rq->avg_irq.util_avg))
return true;
@@ -7516,6 +7519,7 @@ static bool __update_blocked_others(struct rq *rq, bool *done)
{
const struct sched_class *curr_class;
u64 now = rq_clock_pelt(rq);
+ unsigned long thermal_pressure = arch_cpu_thermal_pressure(cpu_of(rq));
bool decayed;
/*
@@ -7526,6 +7530,7 @@ static bool __update_blocked_others(struct rq *rq, bool *done)
decayed = update_rt_rq_load_avg(now, rq, curr_class == &rt_sched_class) |
update_dl_rq_load_avg(now, rq, curr_class == &dl_sched_class) |
+ update_thermal_load_avg(rq_clock_task(rq), rq, thermal_pressure) |
update_irq_load_avg(rq, 0);
if (others_have_blocked(rq))
--
2.1.4
next prev parent reply other threads:[~2020-01-28 22:36 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-28 22:35 [Patch v9 0/8] Introduce Thermal Pressure Thara Gopinath
2020-01-28 22:36 ` [Patch v9 1/8] sched/pelt: Add support to track thermal pressure Thara Gopinath
2020-02-13 12:29 ` Amit Kucheria
2020-02-13 14:11 ` Thara Gopinath
2020-02-13 14:41 ` Amit Kucheria
2020-01-28 22:36 ` [Patch v9 2/8] sched/topology: Add hook to read per cpu " Thara Gopinath
2020-01-28 22:36 ` [Patch v9 3/8] arm,arm64,drivers:Add infrastructure to store and update instantaneous " Thara Gopinath
2020-02-13 12:25 ` Amit Kucheria
2020-02-13 14:05 ` Thara Gopinath
2020-02-13 14:38 ` Amit Kucheria
2020-02-14 15:01 ` Thara Gopinath
2020-01-28 22:36 ` Thara Gopinath [this message]
2020-01-28 22:36 ` [Patch v9 5/8] sched/fair: update cpu_capacity to reflect " Thara Gopinath
2020-02-13 12:47 ` Amit Kucheria
2020-02-13 14:12 ` Thara Gopinath
2020-02-13 13:39 ` Amit Kucheria
2020-02-14 14:52 ` Thara Gopinath
2020-01-28 22:36 ` [Patch v9 6/8] thermal/cpu-cooling: Update thermal pressure in case of a maximum frequency capping Thara Gopinath
2020-01-28 22:36 ` [Patch v9 7/8] sched/fair: Enable tuning of decay period Thara Gopinath
2020-01-28 23:56 ` Randy Dunlap
2020-02-03 12:07 ` Thara Gopinath
2020-02-03 15:55 ` Peter Zijlstra
2020-02-04 8:39 ` Dietmar Eggemann
2020-02-07 22:42 ` Thara Gopinath
2020-02-10 11:59 ` Dietmar Eggemann
2020-02-13 13:54 ` Thara Gopinath
2020-02-14 10:26 ` Dietmar Eggemann
2020-02-18 14:57 ` Thara Gopinath
2020-02-19 9:14 ` Dietmar Eggemann
2020-01-28 22:36 ` [Patch v9 8/8] arm64: Enable averaging of thermal pressure for arm64 based SoCs Thara Gopinath
2020-02-03 8:59 ` Dietmar Eggemann
2020-02-10 12:07 ` [Patch v9 0/8] Introduce Thermal Pressure Dietmar Eggemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1580250967-4386-5-git-send-email-thara.gopinath@linaro.org \
--to=thara.gopinath@linaro.org \
--cc=amit.kachhap@gmail.com \
--cc=amit.kucheria@verdurent.com \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=daniel.lezcano@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=ionela.voinescu@arm.com \
--cc=javi.merino@kernel.org \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=qperret@google.com \
--cc=rostedt@goodmis.org \
--cc=rui.zhang@intel.com \
--cc=sudeep.holla@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).