linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wei Yang <richardw.yang@linux.intel.com>
To: akpm@linux-foundation.org, aneesh.kumar@linux.ibm.com,
	kirill@shutemov.name, dan.j.williams@intel.com,
	yang.shi@linux.alibaba.com, thellstrom@vmware.com,
	richardw.yang@linux.intel.com
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, digetx@gmail.com
Subject: [Patch v2 1/4] mm/mremap: format the check in move_normal_pmd() same as move_huge_pmd()
Date: Wed, 29 Jan 2020 08:26:39 +0800	[thread overview]
Message-ID: <20200129002642.13508-2-richardw.yang@linux.intel.com> (raw)
In-Reply-To: <20200129002642.13508-1-richardw.yang@linux.intel.com>

No functional change, just improve the readability and prepare for
following cleanup.

Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
---
 mm/mremap.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/mm/mremap.c b/mm/mremap.c
index 122938dcec15..bcc7aa62f2d9 100644
--- a/mm/mremap.c
+++ b/mm/mremap.c
@@ -200,8 +200,9 @@ static bool move_normal_pmd(struct vm_area_struct *vma, unsigned long old_addr,
 	struct mm_struct *mm = vma->vm_mm;
 	pmd_t pmd;
 
-	if ((old_addr & ~PMD_MASK) || (new_addr & ~PMD_MASK)
-	    || old_end - old_addr < PMD_SIZE)
+	if ((old_addr & ~PMD_MASK) ||
+	    (new_addr & ~PMD_MASK) ||
+	    old_end - old_addr < PMD_SIZE)
 		return false;
 
 	/*
-- 
2.17.1


  reply	other threads:[~2020-01-29  0:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-29  0:26 [Patch v2 0/4] mm/mremap: cleanup move_page_tables() a little Wei Yang
2020-01-29  0:26 ` Wei Yang [this message]
2020-01-29  0:26 ` [Patch v2 2/4] mm/mremap: it is sure to have enough space when extent meets requirement Wei Yang
2020-01-29  0:26 ` [Patch v2 3/4] mm/mremap: calculate extent in one place Wei Yang
2020-01-29  0:26 ` [Patch v2 4/4] mm/mremap: start addresses are properly aligned Wei Yang
2020-01-30 22:18 ` [Patch v2 0/4] mm/mremap: cleanup move_page_tables() a little Dmitry Osipenko
2020-01-30 23:05   ` Wei Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200129002642.13508-2-richardw.yang@linux.intel.com \
    --to=richardw.yang@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=dan.j.williams@intel.com \
    --cc=digetx@gmail.com \
    --cc=kirill@shutemov.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=thellstrom@vmware.com \
    --cc=yang.shi@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).