From: Tom Zanussi <zanussi@kernel.org>
To: rostedt@goodmis.org
Cc: artem.bityutskiy@linux.intel.com, mhiramat@kernel.org,
linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org
Subject: [PATCH 3/4] tracing: Remove useless code in dynevent_arg_pair_add()
Date: Fri, 31 Jan 2020 15:55:33 -0600 [thread overview]
Message-ID: <7880a1268217886cdba7035526650195668da856.1580506712.git.zanussi@kernel.org> (raw)
In-Reply-To: <cover.1580506712.git.zanussi@kernel.org>
In-Reply-To: <cover.1580506712.git.zanussi@kernel.org>
The final addition to q is unnecessary, since q isn't ever used
afterwards.
Signed-off-by: Tom Zanussi <zanussi@kernel.org>
---
kernel/trace/trace_dynevent.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/trace_dynevent.c b/kernel/trace/trace_dynevent.c
index f9cfcdc9d1f3..204275ec8d71 100644
--- a/kernel/trace/trace_dynevent.c
+++ b/kernel/trace/trace_dynevent.c
@@ -322,7 +322,7 @@ int dynevent_arg_pair_add(struct dynevent_cmd *cmd,
pr_err("field string is too long: %s\n", arg_pair->rhs);
return -E2BIG;
}
- cmd->remaining -= delta; q += delta;
+ cmd->remaining -= delta;
return ret;
}
--
2.14.1
next prev parent reply other threads:[~2020-01-31 21:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 21:55 [PATCH 0/4] tracing: Updates to dynamic event API Tom Zanussi
2020-01-31 21:55 ` [PATCH 1/4] tracing: Consolidate some synth_event_trace code Tom Zanussi
2020-01-31 22:43 ` Steven Rostedt
2020-01-31 22:47 ` Tom Zanussi
2020-01-31 23:00 ` Tom Zanussi
2020-01-31 23:33 ` Steven Rostedt
2020-01-31 21:55 ` [PATCH 2/4] tracing: Remove check_arg() callbacks from dynevent args Tom Zanussi
2020-02-01 7:28 ` Masami Hiramatsu
2020-01-31 21:55 ` Tom Zanussi [this message]
2020-02-01 7:28 ` [PATCH 3/4] tracing: Remove useless code in dynevent_arg_pair_add() Masami Hiramatsu
2020-01-31 21:55 ` [PATCH 4/4] tracing: Use seq_buf for building dynevent_cmd string Tom Zanussi
2020-02-01 7:48 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7880a1268217886cdba7035526650195668da856.1580506712.git.zanussi@kernel.org \
--to=zanussi@kernel.org \
--cc=artem.bityutskiy@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).