[v3,1/2] dt-bindings: arm: realtek: Document RTD1319 and Realtek PymParticle EVB
diff mbox series

Message ID 20200204145207.28622-2-james.tai@realtek.com
State New
Headers show
Series
  • Initial RTD1319 SoC and Realtek PymParticle EVB support
Related show

Commit Message

James Tai [戴志峰] Feb. 4, 2020, 2:52 p.m. UTC
Define compatible strings for Realtek RTD1319 SoC and Realtek PymParticle
EVB.

Signed-off-by: James Tai <james.tai@realtek.com>
---
 v2 -> v3: Unchanged

 v1 -> v2:
 * Put string in alphabetical order

 Documentation/devicetree/bindings/arm/realtek.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Rob Herring Feb. 5, 2020, 4:47 p.m. UTC | #1
On Tue, 4 Feb 2020 22:52:06 +0800, James Tai wrote:
> Define compatible strings for Realtek RTD1319 SoC and Realtek PymParticle
> EVB.
> 
> Signed-off-by: James Tai <james.tai@realtek.com>
> ---
>  v2 -> v3: Unchanged
> 
>  v1 -> v2:
>  * Put string in alphabetical order
> 
>  Documentation/devicetree/bindings/arm/realtek.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.

If a tag was not added on purpose, please state why and what changed.
James Tai [戴志峰] Feb. 7, 2020, 2:53 a.m. UTC | #2
Hi Rob,

> 
> On Tue, 4 Feb 2020 22:52:06 +0800, James Tai wrote:
> > Define compatible strings for Realtek RTD1319 SoC and Realtek
> > PymParticle EVB.
> >
> > Signed-off-by: James Tai <james.tai@realtek.com>
> > ---
> >  v2 -> v3: Unchanged
> >
> >  v1 -> v2:
> >  * Put string in alphabetical order
> >
> >  Documentation/devicetree/bindings/arm/realtek.yaml | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> 
> Please add Acked-by/Reviewed-by tags when posting new versions. However,
> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for acks received on the version they apply.
> 
> If a tag was not added on purpose, please state why and what changed.
> 
I will improve it.

Thank you for your reply.

Regards,
James
Andreas Färber April 13, 2020, 12:17 a.m. UTC | #3
Hi James,

Am 04.02.20 um 15:52 schrieb James Tai:
> Define compatible strings for Realtek RTD1319 SoC and Realtek PymParticle
> EVB.
> 
> Signed-off-by: James Tai <james.tai@realtek.com>
> ---
>   v2 -> v3: Unchanged
> 
>   v1 -> v2:
>   * Put string in alphabetical order
> 
>   Documentation/devicetree/bindings/arm/realtek.yaml | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/realtek.yaml b/Documentation/devicetree/bindings/arm/realtek.yaml
> index 845f9c76d6f7..3b48ae71fdd8 100644
> --- a/Documentation/devicetree/bindings/arm/realtek.yaml
> +++ b/Documentation/devicetree/bindings/arm/realtek.yaml
> @@ -42,6 +42,12 @@ properties:
>                 - synology,ds418 # Synology DiskStation DS418
>             - const: realtek,rtd1296
>   
> +      # RTD1319 SoC based boards
> +      - items:
> +          - enum:
> +              - realtek,pymparticle # Realtek PymParticle EVB

The board seems labelled "PYM_PARTICLES".

While Wikipedia has nothing on that, I found this explanation:
https://marvel.fandom.com/wiki/Pym_Particles

So, are you sure it's PymParticle and not "Pym Particle" with space or 
"Pym Particles" with space and plural S? The S would affect also the 
.dts filename. For the compatible string the question is pymparticle or 
pym-particle.

By comparison, LION-SKIN was named lion-skin in the compatible and 
spelled Lion Skin in textual form. If you believe that should be fixed, 
now would be the time to revisit those patches that didn't make v5.7.

Thanks,
Andreas

> +          - const: realtek,rtd1319
> +
>         # RTD1395 SoC based boards
>         - items:
>             - enum:
James Tai [戴志峰] April 15, 2020, 8:58 a.m. UTC | #4
Hi Andreas,

Thanks for your review!

>
> > diff --git a/Documentation/devicetree/bindings/arm/realtek.yaml
> > b/Documentation/devicetree/bindings/arm/realtek.yaml
> > index 845f9c76d6f7..3b48ae71fdd8 100644
> > --- a/Documentation/devicetree/bindings/arm/realtek.yaml
> > +++ b/Documentation/devicetree/bindings/arm/realtek.yaml
> > @@ -42,6 +42,12 @@ properties:
> >                 - synology,ds418 # Synology DiskStation DS418
> >             - const: realtek,rtd1296
> >
> > +      # RTD1319 SoC based boards
> > +      - items:
> > +          - enum:
> > +              - realtek,pymparticle # Realtek PymParticle EVB
> 
> The board seems labelled "PYM_PARTICLES".
> 
> While Wikipedia has nothing on that, I found this explanation:
> https://marvel.fandom.com/wiki/Pym_Particles
> 
> So, are you sure it's PymParticle and not "Pym Particle" with space or "Pym
> Particles" with space and plural S? The S would affect also the .dts filename.
>
I should change the string to "Pym Particles".

> For the compatible string the question is pymparticle or pym-particle.
> 
The compatible string is "pym-particles".

> By comparison, LION-SKIN was named lion-skin in the compatible and spelled
> Lion Skin in textual form. If you believe that should be fixed, now would be the
> time to revisit those patches that didn't make v5.7.
> 
I'll check those relevant patches.

Thank you.

Regards,
James
Andreas Färber April 15, 2020, 9:19 a.m. UTC | #5
Hi James,

Am 15.04.20 um 10:58 schrieb James Tai [戴志峰]:
>>> diff --git a/Documentation/devicetree/bindings/arm/realtek.yaml
>>> b/Documentation/devicetree/bindings/arm/realtek.yaml
>>> index 845f9c76d6f7..3b48ae71fdd8 100644
>>> --- a/Documentation/devicetree/bindings/arm/realtek.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/realtek.yaml
>>> @@ -42,6 +42,12 @@ properties:
>>>                  - synology,ds418 # Synology DiskStation DS418
>>>              - const: realtek,rtd1296
>>>
>>> +      # RTD1319 SoC based boards
>>> +      - items:
>>> +          - enum:
>>> +              - realtek,pymparticle # Realtek PymParticle EVB
>>
>> The board seems labelled "PYM_PARTICLES".
>>
>> While Wikipedia has nothing on that, I found this explanation:
>> https://marvel.fandom.com/wiki/Pym_Particles
>>
>> So, are you sure it's PymParticle and not "Pym Particle" with space or "Pym
>> Particles" with space and plural S? The S would affect also the .dts filename.
>>
> I should change the string to "Pym Particles".

Okay, in that case I suggest rtd1319-pymparticles.dts for consistency. 
Unless you want to change rtd1395-lionskin.dts to rtd1395-lion-skin.dts.

>> For the compatible string the question is pymparticle or pym-particle.
>>
> The compatible string is "pym-particles".

Works for me. (always assuming we both imply the "realtek," prefix)

If you send a v4, please double-check the comments in patch 2/2.

>> By comparison, LION-SKIN was named lion-skin in the compatible and spelled
>> Lion Skin in textual form. If you believe that should be fixed, now would be the
>> time to revisit those patches that didn't make v5.7.
>>
> I'll check those relevant patches.

Thanks,
Andreas

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/arm/realtek.yaml b/Documentation/devicetree/bindings/arm/realtek.yaml
index 845f9c76d6f7..3b48ae71fdd8 100644
--- a/Documentation/devicetree/bindings/arm/realtek.yaml
+++ b/Documentation/devicetree/bindings/arm/realtek.yaml
@@ -42,6 +42,12 @@  properties:
               - synology,ds418 # Synology DiskStation DS418
           - const: realtek,rtd1296
 
+      # RTD1319 SoC based boards
+      - items:
+          - enum:
+              - realtek,pymparticle # Realtek PymParticle EVB
+          - const: realtek,rtd1319
+
       # RTD1395 SoC based boards
       - items:
           - enum: