From: Gayatri Kammela <gayatri.kammela@intel.com>
To: platform-driver-x86@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, vishwanath.somayaji@intel.com,
dvhart@infradead.org, mika.westerberg@intel.com,
peterz@infradead.org, charles.d.prestopine@intel.com,
Gayatri Kammela <gayatri.kammela@intel.com>,
Srinivas Pandruvada <srinivas.pandruvada@intel.com>,
"David E . Box" <david.e.box@intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v1] platform/x86: intel_pmc_core: Bug: Fix the order of the parameters passed to pmc_core_lpm_display()
Date: Mon, 10 Feb 2020 11:40:38 -0800 [thread overview]
Message-ID: <e0564ff97744f4bf916cd59ecb0d8fdb63806229.1581361984.git.gayatri.kammela@intel.com> (raw)
The parameters passed to pmc_core_lpm_display() which is called by
pmc_core_resume() are not in the right order and hence will not dump the
low power status registers on an S0ix.y failure even if it is compiled
(with warnings).
Fix the bug by passing the parameters in right order.
Cc: Srinivas Pandruvada <srinivas.pandruvada@intel.com>
Cc: David E. Box <david.e.box@intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Gayatri Kammela <gayatri.kammela@intel.com>
---
Hi Andy,
The reason for not catching this bug earlier was not passing the "-Werror"
flag while compiling. I apologize for overlooking the warnings. I wanted to
send v3 of the series, but I have noticed the patch series has been merged in
to for-next branch. I have made sure, no warnings or errors are seen before
sending this fix.
drivers/platform/x86/intel_pmc_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c
index 753d51087838..f4a36fbabf4c 100644
--- a/drivers/platform/x86/intel_pmc_core.c
+++ b/drivers/platform/x86/intel_pmc_core.c
@@ -1326,7 +1326,7 @@ static int pmc_core_resume(struct device *dev)
if (pmcdev->map->slps0_dbg_maps)
pmc_core_slps0_display(pmcdev, dev, NULL);
if (pmcdev->map->lpm_sts)
- pmc_core_lpm_display(pmcdev, dev, NULL, "STATUS", offset, maps);
+ pmc_core_lpm_display(pmcdev, dev, NULL, offset, "STATUS", maps);
return 0;
}
--
2.17.1
reply other threads:[~2020-02-10 19:44 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0564ff97744f4bf916cd59ecb0d8fdb63806229.1581361984.git.gayatri.kammela@intel.com \
--to=gayatri.kammela@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=charles.d.prestopine@intel.com \
--cc=david.e.box@intel.com \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@intel.com \
--cc=peterz@infradead.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=srinivas.pandruvada@intel.com \
--cc=vishwanath.somayaji@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).