[tip/core/rcu,23/30] rcu: Add missing annotation for rcu_nocb_bypass_lock()
diff mbox series

Message ID 20200214235607.13749-23-paulmck@kernel.org
State In Next
Commit 870577357f5d4a3cc0720268ed3a43d4119f45d5
Headers show
  • Miscellaneous fixes for v5.7
Related show

Commit Message

Paul E. McKenney Feb. 14, 2020, 11:56 p.m. UTC
From: Jules Irenge <jbi.octave@gmail.com>

Sparse reports warning at rcu_nocb_bypass_lock()

|warning: context imbalance in rcu_nocb_bypass_lock() - wrong count at exit

To fix this, this commit adds an __acquires(&rdp->nocb_bypass_lock).
Given that rcu_nocb_bypass_lock() does actually call raw_spin_lock()
when raw_spin_trylock() fails, this not only fixes the warning but also
improves on the readability of the code.

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
 kernel/rcu/tree_plugin.h | 1 +
 1 file changed, 1 insertion(+)

diff mbox series

diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
index 0f8b714..6db2cad 100644
--- a/kernel/rcu/tree_plugin.h
+++ b/kernel/rcu/tree_plugin.h
@@ -1486,6 +1486,7 @@  module_param(nocb_nobypass_lim_per_jiffy, int, 0);
  * flag the contention.
 static void rcu_nocb_bypass_lock(struct rcu_data *rdp)
+	__acquires(&rdp->nocb_bypass_lock)
 	if (raw_spin_trylock(&rdp->nocb_bypass_lock))