[1/1] amr64: dts: modify mt8183.dtsi
diff mbox series

Message ID 20200217081922.22544-2-yong.liang@mediatek.com
State In Next
Commit a39f842541038e20063fc880652153c0d93a95bf
Headers show
Series
  • Add watchdog device node
Related show

Commit Message

Yong Liang Feb. 17, 2020, 8:19 a.m. UTC
From: "yong.liang" <yong.liang@mediatek.com>

Add watchdog device node
Document base on http://lists.infradead.org/pipermail/linux-mediatek/2020-January/026415.html

Signed-off-by: yong.liang <yong.liang@mediatek.com>
---
 arch/arm64/boot/dts/mediatek/mt8183.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Matthias Brugger Feb. 17, 2020, 10:05 a.m. UTC | #1
On 17/02/2020 09:19, Yong Liang wrote:
> From: "yong.liang" <yong.liang@mediatek.com>
> 
> Add watchdog device node
> Document base on http://lists.infradead.org/pipermail/linux-mediatek/2020-January/026415.html
> 

Commit message shouldn't contain links to the mailinglist this is additional
information just for review and should go after '---'


> Signed-off-by: yong.liang <yong.liang@mediatek.com>
> ---

Next time please put reference to series your patches are based on here :)

I fixed the commit message (the subject wasn't really usefull, I fixed that too)
and pushed it to v5.6-next/dts64

Thanks,
Matthias

>  arch/arm64/boot/dts/mediatek/mt8183.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index 10b32471bc7b..8b59e0eba2eb 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -253,6 +253,13 @@
>  			#interrupt-cells = <2>;
>  		};
>  
> +		watchdog: watchdog@10007000 {
> +			compatible = "mediatek,mt8183-wdt",
> +				     "mediatek,mt6589-wdt";
> +			reg = <0 0x10007000 0 0x100>;
> +			#reset-cells = <1>;
> +		};
> +
>  		apmixedsys: syscon@1000c000 {
>  			compatible = "mediatek,mt8183-apmixedsys", "syscon";
>  			reg = <0 0x1000c000 0 0x1000>;
>
Yong Liang Feb. 17, 2020, 10:14 a.m. UTC | #2
On Mon, 2020-02-17 at 18:05 +0800, Matthias Brugger wrote:
> 
> On 17/02/2020 09:19, Yong Liang wrote:
> > From: "yong.liang" <yong.liang@mediatek.com>
> > 
> > Add watchdog device node
> > Document base on http://lists.infradead.org/pipermail/linux-mediatek/2020-January/026415.html
> > 
> 
> Commit message shouldn't contain links to the mailinglist this is additional
> information just for review and should go after '---'
> 
> 
> > Signed-off-by: yong.liang <yong.liang@mediatek.com>
> > ---
> 
> Next time please put reference to series your patches are based on here :)
> 
> I fixed the commit message (the subject wasn't really usefull, I fixed that too)
> and pushed it to v5.6-next/dts64
> 
> Thanks,
> Matthias

  Hi Matthias:
     So this patch confirmd to be merged?
     Thansk you very much!
> 
> >  arch/arm64/boot/dts/mediatek/mt8183.dtsi | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > index 10b32471bc7b..8b59e0eba2eb 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > @@ -253,6 +253,13 @@
> >  			#interrupt-cells = <2>;
> >  		};
> >  
> > +		watchdog: watchdog@10007000 {
> > +			compatible = "mediatek,mt8183-wdt",
> > +				     "mediatek,mt6589-wdt";
> > +			reg = <0 0x10007000 0 0x100>;
> > +			#reset-cells = <1>;
> > +		};
> > +
> >  		apmixedsys: syscon@1000c000 {
> >  			compatible = "mediatek,mt8183-apmixedsys", "syscon";
> >  			reg = <0 0x1000c000 0 0x1000>;
> >
Matthias Brugger Feb. 17, 2020, 10:18 a.m. UTC | #3
On 17/02/2020 11:14, Yong Liang wrote:
> On Mon, 2020-02-17 at 18:05 +0800, Matthias Brugger wrote:
>>
>> On 17/02/2020 09:19, Yong Liang wrote:
>>> From: "yong.liang" <yong.liang@mediatek.com>
>>>
>>> Add watchdog device node
>>> Document base on http://lists.infradead.org/pipermail/linux-mediatek/2020-January/026415.html
>>>
>>
>> Commit message shouldn't contain links to the mailinglist this is additional
>> information just for review and should go after '---'
>>
>>
>>> Signed-off-by: yong.liang <yong.liang@mediatek.com>
>>> ---
>>
>> Next time please put reference to series your patches are based on here :)
>>
>> I fixed the commit message (the subject wasn't really usefull, I fixed that too)
>> and pushed it to v5.6-next/dts64
>>
>> Thanks,
>> Matthias
> 
>   Hi Matthias:
>      So this patch confirmd to be merged?

Yes, you can find it here:
https://git.kernel.org/pub/scm/linux/kernel/git/matthias.bgg/linux.git/commit/?h=v5.6-next/dts64&id=a39f842541038e20063fc880652153c0d93a95bf

>      Thansk you very much!

Thanks to you.

Matthias

>>
>>>  arch/arm64/boot/dts/mediatek/mt8183.dtsi | 7 +++++++
>>>  1 file changed, 7 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>>> index 10b32471bc7b..8b59e0eba2eb 100644
>>> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>>> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>>> @@ -253,6 +253,13 @@
>>>  			#interrupt-cells = <2>;
>>>  		};
>>>  
>>> +		watchdog: watchdog@10007000 {
>>> +			compatible = "mediatek,mt8183-wdt",
>>> +				     "mediatek,mt6589-wdt";
>>> +			reg = <0 0x10007000 0 0x100>;
>>> +			#reset-cells = <1>;
>>> +		};
>>> +
>>>  		apmixedsys: syscon@1000c000 {
>>>  			compatible = "mediatek,mt8183-apmixedsys", "syscon";
>>>  			reg = <0 0x1000c000 0 0x1000>;
>>>
>

Patch
diff mbox series

diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index 10b32471bc7b..8b59e0eba2eb 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -253,6 +253,13 @@ 
 			#interrupt-cells = <2>;
 		};
 
+		watchdog: watchdog@10007000 {
+			compatible = "mediatek,mt8183-wdt",
+				     "mediatek,mt6589-wdt";
+			reg = <0 0x10007000 0 0x100>;
+			#reset-cells = <1>;
+		};
+
 		apmixedsys: syscon@1000c000 {
 			compatible = "mediatek,mt8183-apmixedsys", "syscon";
 			reg = <0 0x1000c000 0 0x1000>;