From: Dan Murphy <dmurphy@ti.com>
To: <andrew@lunn.ch>, <f.fainelli@gmail.com>, <hkallweit1@gmail.com>
Cc: <linux@armlinux.org.uk>, <davem@davemloft.net>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<afd@ti.com>, Dan Murphy <dmurphy@ti.com>
Subject: [PATCH net-master] net: phy: dp83848: Add the TI TLK05/06 PHY ID
Date: Wed, 19 Feb 2020 12:16:13 -0600 [thread overview]
Message-ID: <20200219181613.5898-1-dmurphy@ti.com> (raw)
Add the TLK05/06 PHY ID to the DP83848 driver. The TI website indicates
that the DP83822 device is a drop in replacement for the TLK05 device
but the TLK device does not have WoL support. The TLK device is
register compatible to the DP83848 and the DP83848 does not support WoL
either. So this PHY can be associated with the DP83848 driver.
The initial TLKx PHY ID in the driver is a legacy ID and the public data
sheet indicates a new PHY ID. So not to break any kernels out there
both IDs will continue to be supported in this driver.
Signed-off-by: Dan Murphy <dmurphy@ti.com>
---
drivers/net/phy/dp83848.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/phy/dp83848.c b/drivers/net/phy/dp83848.c
index 54c7c1b44e4d..66907cfa816a 100644
--- a/drivers/net/phy/dp83848.c
+++ b/drivers/net/phy/dp83848.c
@@ -12,6 +12,7 @@
#define TI_DP83620_PHY_ID 0x20005ce0
#define NS_DP83848C_PHY_ID 0x20005c90
#define TLK10X_PHY_ID 0x2000a210
+#define TLK105_06_PHY_ID 0x2000a211
/* Registers */
#define DP83848_MICR 0x11 /* MII Interrupt Control Register */
@@ -85,6 +86,7 @@ static struct mdio_device_id __maybe_unused dp83848_tbl[] = {
{ NS_DP83848C_PHY_ID, 0xfffffff0 },
{ TI_DP83620_PHY_ID, 0xfffffff0 },
{ TLK10X_PHY_ID, 0xfffffff0 },
+ { TLK105_06_PHY_ID, 0xfffffff0 },
{ }
};
MODULE_DEVICE_TABLE(mdio, dp83848_tbl);
@@ -115,6 +117,8 @@ static struct phy_driver dp83848_driver[] = {
dp83848_config_init),
DP83848_PHY_DRIVER(TLK10X_PHY_ID, "TI TLK10X 10/100 Mbps PHY",
NULL),
+ DP83848_PHY_DRIVER(TLK105_06_PHY_ID, "TI TLK105/06 10/100 Mbps PHY",
+ NULL),
};
module_phy_driver(dp83848_driver);
--
2.25.0
next reply other threads:[~2020-02-19 18:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 18:16 Dan Murphy [this message]
2020-02-19 18:40 ` [PATCH net-master] net: phy: dp83848: Add the TI TLK05/06 PHY ID Andrew F. Davis
2020-02-19 18:48 ` Andrew Lunn
2020-02-19 18:58 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219181613.5898-1-dmurphy@ti.com \
--to=dmurphy@ti.com \
--cc=afd@ti.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).