From: Chris Packham <chris.packham@alliedtelesis.co.nz>
To: jdelvare@suse.com, linux@roeck-us.net, robh+dt@kernel.org,
mark.rutland@arm.com
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, logan.shaw@alliedtelesis.co.nz,
Chris Packham <chris.packham@alliedtelesis.co.nz>
Subject: [PATCH v4 5/5] hwmon: (adt7475) Add support for inverting pwm output
Date: Fri, 21 Feb 2020 17:16:31 +1300 [thread overview]
Message-ID: <20200221041631.10960-6-chris.packham@alliedtelesis.co.nz> (raw)
In-Reply-To: <20200221041631.10960-1-chris.packham@alliedtelesis.co.nz>
Add a "invert-pwm" device-tree property to allow hardware designs to use
inverted logic on the PWM output. Preserve the invert PWM output bit if
the property is not found to allow for bootloaders/bios which may have
configured this earlier.
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
Notes:
Changes in v4:
- use vendor prefix for new property
Changes in v3:
- New
drivers/hwmon/adt7475.c | 39 +++++++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/drivers/hwmon/adt7475.c b/drivers/hwmon/adt7475.c
index 3649b18359dc..13267181dde6 100644
--- a/drivers/hwmon/adt7475.c
+++ b/drivers/hwmon/adt7475.c
@@ -1509,6 +1509,41 @@ static int load_attenuators(const struct i2c_client *client, int chip,
return 0;
}
+static int adt7475_set_pwm_polarity(struct i2c_client *client)
+{
+ char *prop;
+ int ret, i;
+ u8 val;
+
+ for (i = 0; i < ADT7475_PWM_COUNT; i++) {
+ ret = adt7475_read(PWM_CONFIG_REG(i));
+ if (ret < 0)
+ return ret;
+ val = ret;
+ switch (i) {
+ case 0:
+ prop = "adi,invert-pwm1";
+ break;
+ case 1:
+ prop = "adi,invert-pwm2";
+ break;
+ case 2:
+ prop = "adi,invert-pwm3";
+ break;
+ }
+
+ ret = set_property_bit(client, prop, &val, 4);
+ if (ret)
+ continue;
+
+ ret = i2c_smbus_write_byte_data(client, PWM_CONFIG_REG(i), val);
+ if (ret)
+ return ret;
+ }
+
+ return 0;
+}
+
static int adt7475_probe(struct i2c_client *client,
const struct i2c_device_id *id)
{
@@ -1617,6 +1652,10 @@ static int adt7475_probe(struct i2c_client *client,
for (i = 0; i < ADT7475_PWM_COUNT; i++)
adt7475_read_pwm(client, i);
+ ret = adt7475_set_pwm_polarity(client);
+ if (ret)
+ dev_err(&client->dev, "Error configuring pwm polarity");
+
/* Start monitoring */
switch (chip) {
case adt7475:
--
2.25.0
prev parent reply other threads:[~2020-02-21 4:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 4:16 [PATCH v4 0/5] hwmon: (adt7475) attenuator bypass and pwm invert Chris Packham
2020-02-21 4:16 ` [PATCH v4 1/5] dt-bindings: hwmon: Document adt7475 binding Chris Packham
2020-02-26 16:48 ` Rob Herring
2020-02-21 4:16 ` [PATCH v4 2/5] dt-bindings: hwmon: Document adt7475 bypass-attenuator property Chris Packham
2020-02-26 16:48 ` Rob Herring
2020-02-21 4:16 ` [PATCH v4 3/5] dt-bindings: hwmon: Document adt7475 invert-pwm property Chris Packham
2020-02-21 15:40 ` Rob Herring
2020-02-21 15:52 ` Guenter Roeck
2020-02-21 22:04 ` Rob Herring
2020-02-21 4:16 ` [PATCH v4 4/5] hwmon: (adt7475) Add attenuator bypass support Chris Packham
2020-02-21 4:16 ` Chris Packham [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200221041631.10960-6-chris.packham@alliedtelesis.co.nz \
--to=chris.packham@alliedtelesis.co.nz \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=logan.shaw@alliedtelesis.co.nz \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).