linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: zanussi@kernel.org
To: LKML <linux-kernel@vger.kernel.org>,
	linux-rt-users <linux-rt-users@vger.kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Carsten Emde <C.Emde@osadl.org>, John Kacur <jkacur@redhat.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Daniel Wagner <wagi@monom.org>, Tom Zanussi <zanussi@kernel.org>
Subject: [PATCH RT 20/25] kmemleak: Cosmetic changes
Date: Fri, 21 Feb 2020 15:24:48 -0600	[thread overview]
Message-ID: <c3cf47877f79afa92634bf376488c8aa71378a26.1582320278.git.zanussi@kernel.org> (raw)
In-Reply-To: <cover.1582320278.git.zanussi@kernel.org>
In-Reply-To: <cover.1582320278.git.zanussi@kernel.org>

From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

v4.14.170-rt75-rc1 stable review patch.
If anyone has any objections, please let me know.

-----------


[ Upstream commit 65a387a0b45cdd6844b7c6269e6333c9f0113410 ]

Align with the patch, that got sent upstream for review. Only cosmetic
changes.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Tom Zanussi <zanussi@kernel.org>
---
 mm/kmemleak.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/mm/kmemleak.c b/mm/kmemleak.c
index 17718a11782b..d7925ee4b052 100644
--- a/mm/kmemleak.c
+++ b/mm/kmemleak.c
@@ -26,7 +26,7 @@
  *
  * The following locks and mutexes are used by kmemleak:
  *
- * - kmemleak_lock (raw spinlock): protects the object_list modifications and
+ * - kmemleak_lock (raw_spinlock_t): protects the object_list modifications and
  *   accesses to the object_tree_root. The object_list is the main list
  *   holding the metadata (struct kmemleak_object) for the allocated memory
  *   blocks. The object_tree_root is a red black tree used to look-up
@@ -35,13 +35,13 @@
  *   object_tree_root in the create_object() function called from the
  *   kmemleak_alloc() callback and removed in delete_object() called from the
  *   kmemleak_free() callback
- * - kmemleak_object.lock (spinlock): protects a kmemleak_object. Accesses to
- *   the metadata (e.g. count) are protected by this lock. Note that some
- *   members of this structure may be protected by other means (atomic or
- *   kmemleak_lock). This lock is also held when scanning the corresponding
- *   memory block to avoid the kernel freeing it via the kmemleak_free()
- *   callback. This is less heavyweight than holding a global lock like
- *   kmemleak_lock during scanning
+ * - kmemleak_object.lock (raw_spinlock_t): protects a kmemleak_object.
+ *   Accesses to the metadata (e.g. count) are protected by this lock. Note
+ *   that some members of this structure may be protected by other means
+ *   (atomic or kmemleak_lock). This lock is also held when scanning the
+ *   corresponding memory block to avoid the kernel freeing it via the
+ *   kmemleak_free() callback. This is less heavyweight than holding a global
+ *   lock like kmemleak_lock during scanning.
  * - scan_mutex (mutex): ensures that only one thread may scan the memory for
  *   unreferenced objects at a time. The gray_list contains the objects which
  *   are already referenced or marked as false positives and need to be
@@ -197,7 +197,7 @@ static LIST_HEAD(object_list);
 static LIST_HEAD(gray_list);
 /* search tree for object boundaries */
 static struct rb_root object_tree_root = RB_ROOT;
-/* rw_lock protecting the access to object_list and object_tree_root */
+/* protecting the access to object_list and object_tree_root */
 static DEFINE_RAW_SPINLOCK(kmemleak_lock);
 
 /* allocation caches for kmemleak internal data */
-- 
2.14.1


  parent reply	other threads:[~2020-02-21 21:25 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-21 21:24 [PATCH RT 00/25] Linux v4.14.170-rt75-rc1 zanussi
2020-02-21 21:24 ` [PATCH RT 01/25] Fix wrong-variable use in irq_set_affinity_notifier zanussi
2020-02-21 21:24 ` [PATCH RT 02/25] x86: preempt: Check preemption level before looking at lazy-preempt zanussi
2020-02-21 21:24 ` [PATCH RT 03/25] sched/deadline: Ensure inactive_timer runs in hardirq context zanussi
2020-02-24  8:33   ` Sebastian Andrzej Siewior
2020-02-25 14:50     ` Juri Lelli
2020-02-21 21:24 ` [PATCH RT 04/25] i2c: hix5hd2: Remove IRQF_ONESHOT zanussi
2020-02-21 21:24 ` [PATCH RT 05/25] i2c: exynos5: " zanussi
2020-02-21 21:24 ` [PATCH RT 06/25] sched: migrate_dis/enable: Use sleeping_lock…() to annotate sleeping points zanussi
2020-02-21 21:24 ` [PATCH RT 07/25] sched: __set_cpus_allowed_ptr: Check cpus_mask, not cpus_ptr zanussi
2020-02-21 21:24 ` [PATCH RT 08/25] sched: Remove dead __migrate_disabled() check zanussi
2020-02-21 21:24 ` [PATCH RT 09/25] sched: migrate disable: Protect cpus_ptr with lock zanussi
2020-02-21 21:24 ` [PATCH RT 10/25] lib/smp_processor_id: Don't use cpumask_equal() zanussi
2020-02-21 21:24 ` [PATCH RT 11/25] futex: Make the futex_hash_bucket spinlock_t again and bring back its old state zanussi
2020-02-21 21:24 ` [PATCH RT 12/25] locking/rtmutex: Clean ->pi_blocked_on in the error case zanussi
2020-02-21 21:24 ` [PATCH RT 13/25] lib/ubsan: Don't seralize UBSAN report zanussi
2020-02-21 21:24 ` [PATCH RT 14/25] kmemleak: Change the lock of kmemleak_object to raw_spinlock_t zanussi
2020-02-21 21:24 ` [PATCH RT 15/25] sched: migrate_enable: Use select_fallback_rq() zanussi
2020-02-24  9:43   ` Sebastian Andrzej Siewior
2020-02-24 15:31     ` Tom Zanussi
2020-02-24 16:05       ` Sebastian Andrzej Siewior
2020-02-24 22:15         ` Scott Wood
2020-02-21 21:24 ` [PATCH RT 16/25] Revert "ARM: Initialize split page table locks for vector page" zanussi
2020-02-21 21:24 ` [PATCH RT 17/25] x86/fpu: Don't cache access to fpu_fpregs_owner_ctx zanussi
2020-02-24  8:55   ` Sebastian Andrzej Siewior
2020-02-24 15:12     ` Tom Zanussi
2020-02-21 21:24 ` [PATCH RT 18/25] locking: Make spinlock_t and rwlock_t a RCU section on RT zanussi
2020-02-21 21:24 ` [PATCH RT 19/25] userfaultfd: Use a seqlock instead of seqcount zanussi
2020-02-24  9:03   ` Sebastian Andrzej Siewior
2020-02-24 15:14     ` Tom Zanussi
2020-02-24 16:17     ` Steven Rostedt
2020-02-21 21:24 ` zanussi [this message]
2020-02-24  9:12   ` [PATCH RT 20/25] kmemleak: Cosmetic changes Sebastian Andrzej Siewior
2020-02-24 15:18     ` Tom Zanussi
2020-02-24 15:52       ` Sebastian Andrzej Siewior
2020-02-21 21:24 ` [PATCH RT 21/25] smp: Use smp_cond_func_t as type for the conditional function zanussi
2020-02-24  9:52   ` Sebastian Andrzej Siewior
2020-02-24 15:34     ` Tom Zanussi
2020-02-21 21:24 ` [PATCH RT 22/25] mm/memcontrol: Move misplaced local_unlock_irqrestore() zanussi
2020-02-24  9:55   ` Sebastian Andrzej Siewior
2020-02-21 21:24 ` [PATCH RT 23/25] locallock: Include header for the `current' macro zanussi
2020-02-21 21:24 ` [PATCH RT 24/25] sched: Provide migrate_disable/enable() inlines zanussi
2020-02-21 21:24 ` [PATCH RT 25/25] Linux 4.14.170-rt75-rc1 zanussi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c3cf47877f79afa92634bf376488c8aa71378a26.1582320278.git.zanussi@kernel.org \
    --to=zanussi@kernel.org \
    --cc=C.Emde@osadl.org \
    --cc=bigeasy@linutronix.de \
    --cc=jkacur@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=wagi@monom.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).