From: <masahiro31.yamada@kioxia.com>
To: <kbusch@kernel.org>, <axboe@fb.com>, <hch@lst.de>,
<sagi@grimberg.me>, <linux-nvme@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH] nvme: fix NVME_IOCTL_SUBMIT_IO for compat_ioctl
Date: Fri, 28 Feb 2020 09:28:13 +0000 [thread overview]
Message-ID: <2caa4c913579464bbfdf06b36001ffc9@TGXML281.toshiba.local> (raw)
From: Masahiro Yamada <masahiro31.yamada@kioxia.com>
Currently 32 bit application gets ENOTTY when it calls
compat_ioctl with NVME_IOCTL_SUBMIT_IO in 64 bit kernel.
The cause is that the results of sizeof(struct nvme_user_io),
which is used to define NVME_IOCTL_SUBMIT_IO,
are not same between 32 bit compiler and 64 bit compiler.
* 32 bit: the result of sizeof nvme_user_io is 44.
* 64 bit: the result of sizeof nvme_user_io is 48.
64 bit compiler seems to add 32 bit padding for multiple of 8 bytes.
This patch adds 32 bit padding to struct nvme_user_io
for 32 bit compiler to define same NVME_IOCTL_SUBMIT_IO as 64 bit.
nvme-cli also needs to be fixed if this patch is accepted.
Signed-off-by: Masahiro Yamada <masahiro31.yamada@kioxia.com>
---
include/uapi/linux/nvme_ioctl.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/uapi/linux/nvme_ioctl.h b/include/uapi/linux/nvme_ioctl.h
index d99b5a772698..a50ea474c21a 100644
--- a/include/uapi/linux/nvme_ioctl.h
+++ b/include/uapi/linux/nvme_ioctl.h
@@ -14,7 +14,7 @@ struct nvme_user_io {
__u8 flags;
__u16 control;
__u16 nblocks;
- __u16 rsvd;
+ __u16 rsvd1;
__u64 metadata;
__u64 addr;
__u64 slba;
@@ -22,6 +22,7 @@ struct nvme_user_io {
__u32 reftag;
__u16 apptag;
__u16 appmask;
+ __u32 rsvd2;
};
struct nvme_passthru_cmd {
--
2.20.1
next reply other threads:[~2020-02-28 9:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 9:28 masahiro31.yamada [this message]
2020-02-29 18:59 ` [PATCH] nvme: fix NVME_IOCTL_SUBMIT_IO for compat_ioctl Christoph Hellwig
2020-03-02 4:31 ` masahiro31.yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2caa4c913579464bbfdf06b36001ffc9@TGXML281.toshiba.local \
--to=masahiro31.yamada@kioxia.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).