From: Nathan Chancellor <natechancellor@gmail.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com,
Nathan Chancellor <natechancellor@gmail.com>
Subject: [PATCH] coresight: cti: Remove unnecessary NULL check in cti_sig_type_name
Date: Mon, 2 Mar 2020 14:34:02 -0700 [thread overview]
Message-ID: <20200302213402.9650-1-natechancellor@gmail.com> (raw)
Clang warns:
drivers/hwtracing/coresight/coresight-cti-sysfs.c:948:11: warning:
address of array 'grp->sig_types' will always evaluate to 'true'
[-Wpointer-bool-conversion]
if (grp->sig_types) {
~~ ~~~~~^~~~~~~~~
1 warning generated.
sig_types is at the end of a struct so it cannot be NULL.
Fixes: 85b6684eab65 ("coresight: cti: Add connection information to sysfs")
Link: https://github.com/ClangBuiltLinux/linux/issues/914
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
drivers/hwtracing/coresight/coresight-cti-sysfs.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/hwtracing/coresight/coresight-cti-sysfs.c b/drivers/hwtracing/coresight/coresight-cti-sysfs.c
index abb7f492c2cb..214d6552b494 100644
--- a/drivers/hwtracing/coresight/coresight-cti-sysfs.c
+++ b/drivers/hwtracing/coresight/coresight-cti-sysfs.c
@@ -945,10 +945,8 @@ cti_sig_type_name(struct cti_trig_con *con, int used_count, bool in)
int idx = 0;
struct cti_trig_grp *grp = in ? con->con_in : con->con_out;
- if (grp->sig_types) {
- if (used_count < grp->nr_sigs)
- idx = grp->sig_types[used_count];
- }
+ if (used_count < grp->nr_sigs)
+ idx = grp->sig_types[used_count];
return sig_type_names[idx];
}
--
2.25.1
next reply other threads:[~2020-03-02 21:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 21:34 Nathan Chancellor [this message]
2020-03-02 21:51 ` [PATCH] coresight: cti: Remove unnecessary NULL check in cti_sig_type_name Nick Desaulniers
2020-03-02 21:57 ` Nick Desaulniers
2020-03-04 17:13 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200302213402.9650-1-natechancellor@gmail.com \
--to=natechancellor@gmail.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).