From: Abel Vesa <abel.vesa@nxp.com>
To: Rob Herring <robh@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
Mike Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Lee Jones <lee.jones@linaro.org>,
Anson Huang <anson.huang@nxp.com>,
Leonard Crestez <leonard.crestez@nxp.com>,
Peng Fan <peng.fan@nxp.com>, Jacky Bai <ping.bai@nxp.com>
Cc: NXP Linux Team <linux-imx@nxp.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-clk@vger.kernel.org, Abel Vesa <abel.vesa@nxp.com>
Subject: [RFC 04/11] clk: imx: Add gate shared for i.MX8MP audiomix
Date: Tue, 3 Mar 2020 11:03:19 +0200 [thread overview]
Message-ID: <1583226206-19758-5-git-send-email-abel.vesa@nxp.com> (raw)
In-Reply-To: <1583226206-19758-1-git-send-email-abel.vesa@nxp.com>
The newer i.MX platform use some gates that have a shared control bit
between them.
Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
---
drivers/clk/imx/Makefile | 2 +-
drivers/clk/imx/clk-gate-shared.c | 111 ++++++++++++++++++++++++++++++++++++++
drivers/clk/imx/clk.h | 4 ++
3 files changed, 116 insertions(+), 1 deletion(-)
create mode 100644 drivers/clk/imx/clk-gate-shared.c
diff --git a/drivers/clk/imx/Makefile b/drivers/clk/imx/Makefile
index 928f874c..799a8ef 100644
--- a/drivers/clk/imx/Makefile
+++ b/drivers/clk/imx/Makefile
@@ -27,7 +27,7 @@ obj-$(CONFIG_MXC_CLK_SCU) += \
obj-$(CONFIG_CLK_IMX8MM) += clk-imx8mm.o
obj-$(CONFIG_CLK_IMX8MN) += clk-imx8mn.o
-obj-$(CONFIG_CLK_IMX8MP) += clk-imx8mp.o
+obj-$(CONFIG_CLK_IMX8MP) += clk-imx8mp.o clk-gate-shared.o
obj-$(CONFIG_CLK_IMX8MQ) += clk-imx8mq.o
obj-$(CONFIG_CLK_IMX8QXP) += clk-imx8qxp.o clk-imx8qxp-lpcg.o
diff --git a/drivers/clk/imx/clk-gate-shared.c b/drivers/clk/imx/clk-gate-shared.c
new file mode 100644
index 00000000..961a0e3
--- /dev/null
+++ b/drivers/clk/imx/clk-gate-shared.c
@@ -0,0 +1,111 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright 2019 NXP.
+ */
+
+#include <linux/clk-provider.h>
+#include <linux/err.h>
+#include <linux/io.h>
+#include <linux/slab.h>
+#include "clk.h"
+
+/**
+ * struct clk_gate_shared - i.MX specific gate clock having the gate flag
+ * shared with other gate clocks
+ */
+struct clk_gate_shared {
+ struct clk_gate gate;
+ spinlock_t *lock;
+ unsigned int *share_count;
+};
+
+static int clk_gate_shared_enable(struct clk_hw *hw)
+{
+ struct clk_gate *gate = to_clk_gate(hw);
+ struct clk_gate_shared *shgate = container_of(gate,
+ struct clk_gate_shared, gate);
+ unsigned long flags = 0;
+ int ret = 0;
+
+ spin_lock_irqsave(shgate->lock, flags);
+
+ if (shgate->share_count && (*shgate->share_count)++ > 0)
+ goto out;
+
+ ret = clk_gate_ops.enable(hw);
+out:
+ spin_unlock_irqrestore(shgate->lock, flags);
+
+ return ret;
+}
+
+static void clk_gate_shared_disable(struct clk_hw *hw)
+{
+ struct clk_gate *gate = to_clk_gate(hw);
+ struct clk_gate_shared *shgate = container_of(gate,
+ struct clk_gate_shared, gate);
+ unsigned long flags = 0;
+
+ spin_lock_irqsave(shgate->lock, flags);
+
+ if (shgate->share_count) {
+ if (WARN_ON(*shgate->share_count == 0))
+ goto out;
+ else if (--(*shgate->share_count) > 0)
+ goto out;
+ }
+
+ clk_gate_ops.disable(hw);
+out:
+ spin_unlock_irqrestore(shgate->lock, flags);
+}
+
+static int clk_gate_shared_is_enabled(struct clk_hw *hw)
+{
+ return clk_gate_ops.is_enabled(hw);
+}
+
+static const struct clk_ops clk_gate_shared_ops = {
+ .enable = clk_gate_shared_enable,
+ .disable = clk_gate_shared_disable,
+ .is_enabled = clk_gate_shared_is_enabled,
+};
+
+struct clk_hw *imx_dev_clk_hw_gate_shared(struct device *dev, const char *name,
+ const char *parent, void __iomem *reg,
+ u8 shift, unsigned int *share_count)
+{
+ struct clk_gate_shared *shgate;
+ struct clk_gate *gate;
+ struct clk_hw *hw;
+ struct clk_init_data init;
+ int ret;
+
+ shgate = kzalloc(sizeof(*shgate), GFP_KERNEL);
+ if (!shgate)
+ return ERR_PTR(-ENOMEM);
+ gate = &shgate->gate;
+
+ init.name = name;
+ init.ops = &clk_gate_shared_ops;
+ init.flags = CLK_OPS_PARENT_ENABLE;
+ init.parent_names = parent ? &parent : NULL;
+ init.num_parents = parent ? 1 : 0;
+
+ gate->reg = reg;
+ gate->bit_idx = shift;
+ gate->lock = NULL;
+ gate->hw.init = &init;
+ shgate->lock = &imx_ccm_lock;
+ shgate->share_count = share_count;
+
+ hw = &gate->hw;
+
+ ret = clk_hw_register(NULL, hw);
+ if (ret) {
+ kfree(shgate);
+ return ERR_PTR(ret);
+ }
+
+ return hw;
+}
diff --git a/drivers/clk/imx/clk.h b/drivers/clk/imx/clk.h
index f074dd8..51d6c26 100644
--- a/drivers/clk/imx/clk.h
+++ b/drivers/clk/imx/clk.h
@@ -151,6 +151,10 @@ struct clk_hw *imx_clk_hw_sscg_pll(const char *name,
void __iomem *base,
unsigned long flags);
+struct clk_hw *imx_dev_clk_hw_gate_shared(struct device *dev, const char *name,
+ const char *parent, void __iomem *reg,
+ u8 shift, unsigned int *share_count);
+
enum imx_pllv3_type {
IMX_PLLV3_GENERIC,
IMX_PLLV3_SYS,
--
2.7.4
next prev parent reply other threads:[~2020-03-03 9:03 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 9:03 [RFC 00/11] Add generic MFD i.MX mix and audiomix support Abel Vesa
2020-03-03 9:03 ` [RFC 01/11] mfd: Add i.MX generic mix support Abel Vesa
2020-03-26 11:03 ` Lee Jones
2020-03-26 12:30 ` Abel Vesa
2020-03-03 9:03 ` [RFC 02/11] arm64: dts: imx8mp: Add AIPS 4 and 5 Abel Vesa
2020-03-13 7:44 ` Peng Fan
2020-03-23 10:48 ` Abel Vesa
2020-03-03 9:03 ` [RFC 03/11] arm64: dts: imx8mp: Add audiomix node Abel Vesa
2020-03-03 9:03 ` Abel Vesa [this message]
2020-03-13 7:47 ` [RFC 04/11] clk: imx: Add gate shared for i.MX8MP audiomix Peng Fan
2020-03-03 9:03 ` [RFC 05/11] clk: imx: pll14xx: Add the device as argument when registering Abel Vesa
2020-03-13 7:50 ` Peng Fan
2020-03-21 0:46 ` Stephen Boyd
2020-03-03 9:03 ` [RFC 06/11] clk: imx: Add helpers for passing the device as argument Abel Vesa
2020-03-13 7:58 ` Peng Fan
2020-03-21 0:46 ` Stephen Boyd
2020-03-03 9:03 ` [RFC 07/11] dt-bindings: clocks: imx8mp: Add ids for audiomix clocks Abel Vesa
2020-03-10 20:17 ` Rob Herring
2020-03-21 0:51 ` Stephen Boyd
2020-03-03 9:03 ` [RFC 08/11] clk: imx: Add audiomix clock controller support Abel Vesa
2020-03-21 0:51 ` Stephen Boyd
2020-03-03 9:03 ` [RFC 09/11] arm64: dts: imx8mp: Add audiomix clock controller node Abel Vesa
2020-03-03 9:03 ` [RFC 10/11] reset: imx: Add audiomix reset controller support Abel Vesa
2020-03-04 11:41 ` Philipp Zabel
2020-03-13 14:16 ` Abel Vesa
2020-03-13 15:55 ` Philipp Zabel
2020-03-18 11:08 ` Abel Vesa
2020-03-10 20:19 ` Rob Herring
2020-03-03 9:03 ` [RFC 11/11] arm64: dts: imx8mp: Add audiomix reset controller node Abel Vesa
2020-04-16 11:06 ` [RFC 00/11] Add generic MFD i.MX mix and audiomix support Arnd Bergmann
2020-04-16 11:06 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1583226206-19758-5-git-send-email-abel.vesa@nxp.com \
--to=abel.vesa@nxp.com \
--cc=anson.huang@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peng.fan@nxp.com \
--cc=ping.bai@nxp.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).