From: Cyrill Gorcunov <gorcunov@gmail.com>
To: mingo@elte.hu, tglx@linutronix.de, hpa@zytor.com, macro@linux-mips.org
Cc: Cyrill Gorcunov <gorcunov@gmail.com>, linux-kernel@vger.kernel.org
Subject: [patch 3/5] x86: nmi_watchdog - remove useless check
Date: Thu, 01 Jan 1970 03:00:03 +0300 [thread overview]
Message-ID: <48611ec1.2234440a.679b.1a7c@mx.google.com> (raw)
In-Reply-To: 20080624161624.124913675@gmail.com
[-- Attachment #1: nmi-reduce-check --]
[-- Type: text/plain, Size: 794 bytes --]
Since nmi_watchdog is unsigned variable we may
safely remove the check for negative value
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
Index: linux-2.6.git/arch/x86/kernel/nmi.c
====================================================================
--- linux-2.6.git.orig/arch/x86/kernel/nmi.c 2008-06-22 23:02:50.000000000 +0400
+++ linux-2.6.git/arch/x86/kernel/nmi.c 2008-06-23 20:02:47.000000000 +0400
@@ -186,7 +186,7 @@ error:
static int __init setup_nmi_watchdog(char *str)
{
- int nmi;
+ unsigned int nmi;
if (!strncmp(str, "panic", 5)) {
panic_on_timeout = 1;
@@ -198,7 +198,7 @@ static int __init setup_nmi_watchdog(cha
get_option(&str, &nmi);
- if (nmi >= NMI_INVALID || nmi < NMI_NONE)
+ if (nmi >= NMI_INVALID)
return 0;
nmi_watchdog = nmi;
--
next prev parent reply other threads:[~2008-06-24 16:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080624161624.124913675@gmail.com>
1970-01-01 0:00 ` [patch 1/5] x86: perfctr-watchdog.c - coding style cleanup Cyrill Gorcunov
2008-06-24 16:36 ` Ingo Molnar
2008-06-24 16:45 ` Cyrill Gorcunov
2008-06-24 20:43 ` Ingo Molnar
2008-06-25 3:18 ` Cyrill Gorcunov
1970-01-01 0:00 ` [patch 2/5] x86: nmi_watchdog - use nmi_watchdog variable for printing Cyrill Gorcunov
1970-01-01 0:00 ` Cyrill Gorcunov [this message]
1970-01-01 0:00 ` [patch 4/5] x86: nmi_watchdog - use NMI_NONE by default Cyrill Gorcunov
1970-01-01 0:00 ` [patch 5/5] x86: nmi_watchdog - introduce nmi_watchdog_active() helper Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48611ec1.2234440a.679b.1a7c@mx.google.com \
--to=gorcunov@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).