From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Peter Wu <peter@lekensteyn.nl>, Jonathan Corbet <corbet@lwn.net>,
Tom Zanussi <zanussi@kernel.org>
Subject: [RFC][PATCH 08/11] ring-buffer: Do not disable recording when there is an iterator
Date: Tue, 17 Mar 2020 17:32:30 -0400 [thread overview]
Message-ID: <20200317213416.759770696@goodmis.org> (raw)
In-Reply-To: 20200317213222.421100128@goodmis.org
From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
Now that the iterator can handle a concurrent writer, do not disable writing
to the ring buffer when there is an iterator present.
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
kernel/trace/ring_buffer.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
index 5979327254f9..8bafba674ec0 100644
--- a/kernel/trace/ring_buffer.c
+++ b/kernel/trace/ring_buffer.c
@@ -4295,7 +4295,6 @@ ring_buffer_read_prepare(struct trace_buffer *buffer, int cpu, gfp_t flags)
iter->cpu_buffer = cpu_buffer;
atomic_inc(&buffer->resize_disabled);
- atomic_inc(&cpu_buffer->record_disabled);
return iter;
}
@@ -4368,7 +4367,6 @@ ring_buffer_read_finish(struct ring_buffer_iter *iter)
rb_check_pages(cpu_buffer);
raw_spin_unlock_irqrestore(&cpu_buffer->reader_lock, flags);
- atomic_dec(&cpu_buffer->record_disabled);
atomic_dec(&cpu_buffer->buffer->resize_disabled);
kfree(iter->event);
kfree(iter);
--
2.25.1
next prev parent reply other threads:[~2020-03-17 21:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 21:32 [RFC][PATCH 00/11] ring-buffer/tracing: Remove disabling of ring buffer while reading trace file Steven Rostedt
2020-03-17 21:32 ` [RFC][PATCH 01/11] tracing: Save off entry when peeking at next entry Steven Rostedt
2020-03-19 13:41 ` Masami Hiramatsu
2020-03-19 19:53 ` Steven Rostedt
2020-03-17 21:32 ` [RFC][PATCH 02/11] ring-buffer: Have ring_buffer_empty() not depend on tracing stopped Steven Rostedt
2020-03-17 21:32 ` [RFC][PATCH 03/11] ring-buffer: Rename ring_buffer_read() to read_buffer_iter_advance() Steven Rostedt
2020-03-17 21:32 ` [RFC][PATCH 04/11] ring-buffer: Add page_stamp to iterator for synchronization Steven Rostedt
2020-03-17 21:32 ` [RFC][PATCH 05/11] ring-buffer: Have rb_iter_head_event() handle concurrent writer Steven Rostedt
2020-03-17 21:32 ` [RFC][PATCH 06/11] ring-buffer: Do not die if rb_iter_peek() fails more than thrice Steven Rostedt
2020-03-17 21:32 ` [RFC][PATCH 07/11] ring-buffer: Optimize rb_iter_head_event() Steven Rostedt
2020-03-17 21:32 ` Steven Rostedt [this message]
2020-03-17 21:32 ` [RFC][PATCH 09/11] tracing: Do not disable tracing when reading the trace file Steven Rostedt
2020-03-17 21:32 ` [RFC][PATCH 10/11] ring-buffer/tracing: Have iterator acknowledge dropped events Steven Rostedt
2020-03-17 21:32 ` [RFC][PATCH 11/11] tracing: Have the document reflect that the trace file keeps tracing enabled Steven Rostedt
2020-03-18 15:13 ` [RFC][PATCH 12/11] selftest/ftrace: Fix function trigger test to handle trace not disabling the tracer Steven Rostedt
2020-03-18 16:35 ` Shuah Khan
2020-03-19 13:04 ` Masami Hiramatsu
2020-03-19 5:27 ` [RFC][PATCH 00/11] ring-buffer/tracing: Remove disabling of ring buffer while reading trace file Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317213416.759770696@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=alexei.starovoitov@gmail.com \
--cc=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=peter@lekensteyn.nl \
--cc=peterz@infradead.org \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).