From: Randy Dunlap <rdunlap@infradead.org>
To: Linux MM <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH -next] mm/hugetlb.c: fix printk format warning for 32-bit phys_addr_t
Date: Wed, 18 Mar 2020 14:33:19 -0700 [thread overview]
Message-ID: <b74dcb60-ef35-f06e-de2d-b165ed38036a@infradead.org> (raw)
From: Randy Dunlap <rdunlap@infradead.org>
Fix printk format warnings when phys_addr_t is 32 bits, i.e.,
CONFIG_PHYS_ADDR_T_64BIT is not set/enabled.
Fixes these build warnings:
CC mm/hugetlb.o
In file included from ../include/linux/printk.h:7:0,
from ../include/linux/kernel.h:15,
from ../include/linux/list.h:9,
from ../mm/hugetlb.c:6:
../mm/hugetlb.c: In function ‘hugetlb_cma_reserve’:
../include/linux/kern_levels.h:5:18: warning: format ‘%llu’ expects argument of type ‘long long unsigned int’, but argument 4 has type ‘unsigned int’ [-Wformat=]
#define KERN_SOH "\001" /* ASCII Start Of Header */
^
../include/linux/kern_levels.h:12:22: note: in expansion of macro ‘KERN_SOH’
#define KERN_WARNING KERN_SOH "4" /* warning conditions */
^~~~~~~~
../include/linux/printk.h:306:9: note: in expansion of macro ‘KERN_WARNING’
printk(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~~~~~
../mm/hugetlb.c:5472:4: note: in expansion of macro ‘pr_warn’
pr_warn("hugetlb_cma: reservation failed: err %d, node %d, [%llu, %llu)",
^~~~~~~
../mm/hugetlb.c:5472:67: note: format string is defined here
pr_warn("hugetlb_cma: reservation failed: err %d, node %d, [%llu, %llu)",
~~~^
%u
In file included from ../include/linux/printk.h:7:0,
from ../include/linux/kernel.h:15,
from ../include/linux/list.h:9,
from ../mm/hugetlb.c:6:
../include/linux/kern_levels.h:5:18: warning: format ‘%llu’ expects argument of type ‘long long unsigned int’, but argument 5 has type ‘unsigned int’ [-Wformat=]
#define KERN_SOH "\001" /* ASCII Start Of Header */
^
../include/linux/kern_levels.h:12:22: note: in expansion of macro ‘KERN_SOH’
#define KERN_WARNING KERN_SOH "4" /* warning conditions */
^~~~~~~~
../include/linux/printk.h:306:9: note: in expansion of macro ‘KERN_WARNING’
printk(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~~~~~
../mm/hugetlb.c:5472:4: note: in expansion of macro ‘pr_warn’
pr_warn("hugetlb_cma: reservation failed: err %d, node %d, [%llu, %llu)",
^~~~~~~
../mm/hugetlb.c:5472:73: note: format string is defined here
pr_warn("hugetlb_cma: reservation failed: err %d, node %d, [%llu, %llu)",
~~~^
%u
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
mm/hugetlb.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
--- linux-next-20200318.orig/mm/hugetlb.c
+++ linux-next-20200318/mm/hugetlb.c
@@ -5469,8 +5469,10 @@ void __init hugetlb_cma_reserve(int orde
0, false,
"hugetlb", &hugetlb_cma[nid]);
if (res) {
- pr_warn("hugetlb_cma: reservation failed: err %d, node %d, [%llu, %llu)",
- res, nid, PFN_PHYS(min_pfn), PFN_PHYS(max_pfn));
+ phys_addr_t begpa = PFN_PHYS(min_pfn);
+ phys_addr_t endpa = PFN_PHYS(max_pfn);
+ pr_warn("hugetlb_cma: reservation failed: err %d, node %d, [%pap, %pap)",
+ res, nid, &begpa, &endpa);
break;
}
next reply other threads:[~2020-03-18 21:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 21:33 Randy Dunlap [this message]
2020-03-19 2:04 ` [PATCH -next] mm/hugetlb.c: fix printk format warning for 32-bit phys_addr_t Joe Perches
2020-03-19 2:11 ` Randy Dunlap
2020-03-19 2:37 ` Joe Perches
2020-03-20 1:03 ` Randy Dunlap
2020-03-20 1:06 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b74dcb60-ef35-f06e-de2d-b165ed38036a@infradead.org \
--to=rdunlap@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).