linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Brauner <christian.brauner@ubuntu.com>
To: "David S. Miller" <davem@davemloft.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	Pavel Machek <pavel@ucw.cz>, Jakub Kicinski <kuba@kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	Stephen Hemminger <stephen@networkplumber.org>,
	linux-pm@vger.kernel.org, Randy Dunlap <rdunlap@infradead.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Christian Brauner <christian.brauner@ubuntu.com>
Subject: [PATCH net-next] sysfs: fix static inline declaration of sysfs_groups_change_owner()
Date: Thu, 19 Mar 2020 15:47:41 +0100	[thread overview]
Message-ID: <20200319144741.3864191-1-christian.brauner@ubuntu.com> (raw)
In-Reply-To: <20200319142002.7382ed70@canb.auug.org.au>

The CONFIG_SYSFS declaration of sysfs_group_change_owner() is different
from the !CONFIG_SYSFS version and thus causes build failurs when
!CONFIG_SYSFS is set.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Fixes: 303a42769c4c ("sysfs: add sysfs_group{s}_change_owner()")
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
---
 include/linux/sysfs.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h
index 9e531ec76274..4beb51009b62 100644
--- a/include/linux/sysfs.h
+++ b/include/linux/sysfs.h
@@ -562,8 +562,8 @@ static inline int sysfs_groups_change_owner(struct kobject *kobj,
 }
 
 static inline int sysfs_group_change_owner(struct kobject *kobj,
-			 const struct attribute_group **groups,
-			 kuid_t kuid, kgid_t kgid)
+					   const struct attribute_group *groups,
+					   kuid_t kuid, kgid_t kgid)
 {
 	return 0;
 }

base-commit: 79e28519ac78dde6d38fe6ea22286af574f5c7db
-- 
2.25.2


  reply	other threads:[~2020-03-19 14:48 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-18 11:09 linux-next: Tree for Mar 18 Stephen Rothwell
2020-03-18 16:14 ` linux-next: Tree for Mar 18 (drivers/base/power/sysfs.c) Randy Dunlap
2020-03-19  3:20   ` Stephen Rothwell
2020-03-19 14:47     ` Christian Brauner [this message]
2020-03-19 16:19       ` [PATCH net-next] sysfs: fix static inline declaration of sysfs_groups_change_owner() Randy Dunlap
2020-03-20  4:17       ` David Miller
2020-03-18 16:48 ` linux-next: Tree for Mar 18 (objtool) Randy Dunlap
2020-03-18 16:55   ` Josh Poimboeuf
2020-03-18 18:23   ` Josh Poimboeuf
2020-03-18 20:05     ` Peter Zijlstra
2020-03-19 11:12       ` Peter Zijlstra
2020-03-19 17:31       ` Josh Poimboeuf
2020-03-19 17:33         ` Josh Poimboeuf
2020-03-19 17:40           ` Josh Poimboeuf
2020-03-19 17:45             ` Josh Poimboeuf
2020-03-20  8:26               ` Peter Zijlstra
2020-03-20 18:35                 ` Kees Cook
2020-03-24 16:44                   ` Josh Poimboeuf
2020-03-24 18:18                     ` Kees Cook
2020-03-24 22:24                       ` Josh Poimboeuf
2020-03-26  5:57                         ` Kees Cook
2020-03-26 16:31                           ` Josh Poimboeuf
2020-03-26 18:36                             ` Kees Cook
2020-03-27  3:55                               ` Josh Poimboeuf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200319144741.3864191-1-christian.brauner@ubuntu.com \
    --to=christian.brauner@ubuntu.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rafael@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=sfr@canb.auug.org.au \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).