From: mateusznosek0@gmail.com
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: Mateusz Nosek <mateusznosek0@gmail.com>, akpm@linux-foundation.org
Subject: [PATCH] mm/vmscan.c: Clean code by removing unnecessary assignment
Date: Thu, 19 Mar 2020 17:59:38 +0100 [thread overview]
Message-ID: <20200319165938.23354-1-mateusznosek0@gmail.com> (raw)
From: Mateusz Nosek <mateusznosek0@gmail.com>
Previously 0 was assigned to 'sc->skipped_deactivate'. It could happen only
if 'sc->skipped_deactivate' was 0 so the assignment is unnecessary and can
be removed.
Signed-off-by: Mateusz Nosek <mateusznosek0@gmail.com>
---
mm/vmscan.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index dca623db51c8..453ff2abcb58 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -3093,7 +3093,6 @@ static unsigned long do_try_to_free_pages(struct zonelist *zonelist,
if (sc->memcg_low_skipped) {
sc->priority = initial_priority;
sc->force_deactivate = 0;
- sc->skipped_deactivate = 0;
sc->memcg_low_reclaim = 1;
sc->memcg_low_skipped = 0;
goto retry;
--
2.17.1
next reply other threads:[~2020-03-19 17:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 16:59 mateusznosek0 [this message]
2020-03-19 17:13 ` [PATCH] mm/vmscan.c: Clean code by removing unnecessary assignment Michal Hocko
2020-03-20 15:55 ` Johannes Weiner
-- strict thread matches above, loose matches on Subject: below --
2020-02-29 21:40 mateusznosek0
2020-03-01 0:11 ` Matthew Wilcox
2020-03-02 13:54 ` Wei Yang
2020-03-03 8:59 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200319165938.23354-1-mateusznosek0@gmail.com \
--to=mateusznosek0@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).