[2/2] thermal: core: Remove pointless debug traces
diff mbox series

Message ID 20200331165449.30355-2-daniel.lezcano@linaro.org
State Accepted
Commit 44fc73223eebaf4a0c970072819d34ff1d92ce7b
Headers show
Series
  • [1/2] thermal: core: Make thermal_zone_set_trips private
Related show

Commit Message

Daniel Lezcano March 31, 2020, 4:54 p.m. UTC
The last temperature and the current temperature are show via a
dev_debug. The line before, those temperature are also traced.

It is pointless to duplicate the traces for the temperatures,
remove the dev_dbg traces.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/thermal/thermal_core.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Lukasz Luba April 1, 2020, 7:29 a.m. UTC | #1
Hi Daniel,

On 3/31/20 5:54 PM, Daniel Lezcano wrote:
> The last temperature and the current temperature are show via a
> dev_debug. The line before, those temperature are also traced.
> 
> It is pointless to duplicate the traces for the temperatures,
> remove the dev_dbg traces.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
>   drivers/thermal/thermal_core.c | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> index 9a321dc548c8..c06550930979 100644
> --- a/drivers/thermal/thermal_core.c
> +++ b/drivers/thermal/thermal_core.c
> @@ -447,12 +447,6 @@ static void update_temperature(struct thermal_zone_device *tz)
>   	mutex_unlock(&tz->lock);
>   
>   	trace_thermal_temperature(tz);
> -	if (tz->last_temperature == THERMAL_TEMP_INVALID)
> -		dev_dbg(&tz->device, "last_temperature N/A, current_temperature=%d\n",
> -			tz->temperature);
> -	else
> -		dev_dbg(&tz->device, "last_temperature=%d, current_temperature=%d\n",
> -			tz->last_temperature, tz->temperature);
>   }
>   
>   static void thermal_zone_device_init(struct thermal_zone_device *tz)
> 

This prints really deserve to be removed.

Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>

Regards,
Lukasz
Amit Kucheria April 1, 2020, 8:20 a.m. UTC | #2
On Tue, Mar 31, 2020 at 10:27 PM Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
>
> The last temperature and the current temperature are show via a
> dev_debug. The line before, those temperature are also traced.
>
> It is pointless to duplicate the traces for the temperatures,
> remove the dev_dbg traces.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>

Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>

> ---
>  drivers/thermal/thermal_core.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> index 9a321dc548c8..c06550930979 100644
> --- a/drivers/thermal/thermal_core.c
> +++ b/drivers/thermal/thermal_core.c
> @@ -447,12 +447,6 @@ static void update_temperature(struct thermal_zone_device *tz)
>         mutex_unlock(&tz->lock);
>
>         trace_thermal_temperature(tz);
> -       if (tz->last_temperature == THERMAL_TEMP_INVALID)
> -               dev_dbg(&tz->device, "last_temperature N/A, current_temperature=%d\n",
> -                       tz->temperature);
> -       else
> -               dev_dbg(&tz->device, "last_temperature=%d, current_temperature=%d\n",
> -                       tz->last_temperature, tz->temperature);
>  }
>
>  static void thermal_zone_device_init(struct thermal_zone_device *tz)
> --
> 2.17.1
>

Patch
diff mbox series

diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index 9a321dc548c8..c06550930979 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -447,12 +447,6 @@  static void update_temperature(struct thermal_zone_device *tz)
 	mutex_unlock(&tz->lock);
 
 	trace_thermal_temperature(tz);
-	if (tz->last_temperature == THERMAL_TEMP_INVALID)
-		dev_dbg(&tz->device, "last_temperature N/A, current_temperature=%d\n",
-			tz->temperature);
-	else
-		dev_dbg(&tz->device, "last_temperature=%d, current_temperature=%d\n",
-			tz->last_temperature, tz->temperature);
 }
 
 static void thermal_zone_device_init(struct thermal_zone_device *tz)