From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: linux-hyperv@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Wei Liu <wei.liu@kernel.org>,
Tianyu Lan <Tianyu.Lan@microsoft.com>,
Michael Kelley <mikelley@microsoft.com>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
"Andrea Parri (Microsoft)" <parri.andrea@gmail.com>
Subject: [PATCH 4/5] Drivers: hv: make sure that 'struct vmbus_channel_message_header' compiles correctly
Date: Wed, 1 Apr 2020 12:38:15 +0200 [thread overview]
Message-ID: <20200401103816.1406642-1-vkuznets@redhat.com> (raw)
In-Reply-To: <20200401103638.1406431-1-vkuznets@redhat.com>
Strictly speaking, compiler is free to use something different from 'u32'
for 'enum vmbus_channel_message_type' (e.g. char) but it doesn't happen in
real life, just add a BUILD_BUG_ON() guardian.
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
---
drivers/hv/vmbus_drv.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index 0f7bbf952d89..d684cbee7ae6 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv/vmbus_drv.c
@@ -1023,6 +1023,13 @@ void vmbus_on_msg_dpc(unsigned long data)
struct onmessage_work_context *ctx;
u32 message_type = msg->header.message_type;
+ /*
+ * 'enum vmbus_channel_message_type' is supposed to always be 'u32' as
+ * it is being used in 'struct vmbus_channel_message_header' definition
+ * which is supposed to match hypervisor ABI.
+ */
+ BUILD_BUG_ON(sizeof(enum vmbus_channel_message_type) != sizeof(u32));
+
if (message_type == HVMSG_NONE)
/* no msg */
return;
--
2.25.1
next prev parent reply other threads:[~2020-04-01 10:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 10:36 [PATCH 0/5] Drivers: hv: cleanup VMBus messages handling Vitaly Kuznetsov
2020-04-01 10:36 ` [PATCH 1/5] Drivers: hv: copy from message page only what's needed Vitaly Kuznetsov
2020-04-02 14:46 ` [EXTERNAL] " 163
2020-04-02 16:26 ` Vitaly Kuznetsov
2020-04-03 1:52 ` Michael Kelley
2020-04-03 7:03 ` Vitaly Kuznetsov
2020-04-01 10:36 ` [PATCH 2/5] Drivers: hv: allocate the exact needed memory for messages Vitaly Kuznetsov
2020-04-03 1:54 ` Michael Kelley
2020-04-01 10:36 ` [PATCH 3/5] Drivers: hv: avoid passing opaque pointer to vmbus_onmessage() Vitaly Kuznetsov
2020-04-03 1:55 ` Michael Kelley
2020-04-01 10:38 ` Vitaly Kuznetsov [this message]
2020-04-01 10:38 ` [PATCH 5/5] Drivers: hv: check VMBus messages lengths Vitaly Kuznetsov
2020-04-03 2:00 ` Michael Kelley
2020-04-03 7:07 ` Vitaly Kuznetsov
2020-04-03 1:56 ` [PATCH 4/5] Drivers: hv: make sure that 'struct vmbus_channel_message_header' compiles correctly Michael Kelley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200401103816.1406642-1-vkuznets@redhat.com \
--to=vkuznets@redhat.com \
--cc=Tianyu.Lan@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=parri.andrea@gmail.com \
--cc=sthemmin@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).