From: Tang Bin <tangbin@cmss.chinamobile.com>
To: robdclark@gmail.com, agross@kernel.org
Cc: bjorn.andersson@linaro.org, joro@8bytes.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Tang Bin <tangbin@cmss.chinamobile.com>
Subject: [PATCH] iommu/qcom:fix local_base status check
Date: Wed, 1 Apr 2020 23:20:08 +0800 [thread overview]
Message-ID: <20200401152008.16740-1-tangbin@cmss.chinamobile.com> (raw)
Release resources when exiting on error.
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
drivers/iommu/qcom_iommu.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/iommu/qcom_iommu.c b/drivers/iommu/qcom_iommu.c
index 4328da0b0..d4ec38b1e 100644
--- a/drivers/iommu/qcom_iommu.c
+++ b/drivers/iommu/qcom_iommu.c
@@ -815,6 +815,8 @@ static int qcom_iommu_device_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (res)
qcom_iommu->local_base = devm_ioremap_resource(dev, res);
+ if (IS_ERR(qcom_iommu->local_base))
+ return PTR_ERR(qcom_iommu->local_base);
qcom_iommu->iface_clk = devm_clk_get(dev, "iface");
if (IS_ERR(qcom_iommu->iface_clk)) {
--
2.20.1.windows.1
next reply other threads:[~2020-04-01 15:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 15:20 Tang Bin [this message]
2020-04-01 23:36 ` [PATCH] iommu/qcom:fix local_base status check Bjorn Andersson
2020-04-02 6:33 Tang Bin
2020-04-02 6:45 ` Bjorn Andersson
2020-04-16 6:42 ` Tang Bin
2020-04-18 11:54 ` Joerg Roedel
2020-04-18 13:08 ` Tang Bin
2020-04-16 10:05 ` Robin Murphy
2020-04-16 10:12 ` Tang Bin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200401152008.16740-1-tangbin@cmss.chinamobile.com \
--to=tangbin@cmss.chinamobile.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=joro@8bytes.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).