From: Haren Myneni <haren@linux.ibm.com>
To: mpe@ellerman.id.au
Cc: npiggin@gmail.com, mikey@neuling.org,
herbert@gondor.apana.org.au, frederic.barrat@fr.ibm.com,
srikar@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
hch@infradead.org, oohall@gmail.com, clg@kaod.org,
sukadev@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org,
ajd@linux.ibm.com
Subject: [PATCH v9 11/13] powerpc/vas: Do not use default credits for receive window
Date: Wed, 01 Apr 2020 14:31:06 -0700 [thread overview]
Message-ID: <1585776666.10664.455.camel@hbabu-laptop> (raw)
In-Reply-To: <1585775978.10664.438.camel@hbabu-laptop>
System checkstops if RxFIFO overruns with more requests than the
maximum possible number of CRBs allowed in FIFO at any time. So
max credits value (rxattr.wcreds_max) is set and is passed to
vas_rx_win_open() by the the driver.
Signed-off-by: Haren Myneni <haren@linux.ibm.com>
---
arch/powerpc/platforms/powernv/vas-window.c | 4 ++--
arch/powerpc/platforms/powernv/vas.h | 2 --
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/platforms/powernv/vas-window.c b/arch/powerpc/platforms/powernv/vas-window.c
index 33aaa7a..084e76b 100644
--- a/arch/powerpc/platforms/powernv/vas-window.c
+++ b/arch/powerpc/platforms/powernv/vas-window.c
@@ -772,7 +772,7 @@ static bool rx_win_args_valid(enum vas_cop_type cop,
if (attr->rx_fifo_size > VAS_RX_FIFO_SIZE_MAX)
return false;
- if (attr->wcreds_max > VAS_RX_WCREDS_MAX)
+ if (!attr->wcreds_max)
return false;
if (attr->nx_win) {
@@ -877,7 +877,7 @@ struct vas_window *vas_rx_win_open(int vasid, enum vas_cop_type cop,
rxwin->nx_win = rxattr->nx_win;
rxwin->user_win = rxattr->user_win;
rxwin->cop = cop;
- rxwin->wcreds_max = rxattr->wcreds_max ?: VAS_WCREDS_DEFAULT;
+ rxwin->wcreds_max = rxattr->wcreds_max;
init_winctx_for_rxwin(rxwin, rxattr, &winctx);
init_winctx_regs(rxwin, &winctx);
diff --git a/arch/powerpc/platforms/powernv/vas.h b/arch/powerpc/platforms/powernv/vas.h
index efdaa28..32b5261 100644
--- a/arch/powerpc/platforms/powernv/vas.h
+++ b/arch/powerpc/platforms/powernv/vas.h
@@ -101,11 +101,9 @@
/*
* Initial per-process credits.
* Max send window credits: 4K-1 (12-bits in VAS_TX_WCRED)
- * Max receive window credits: 64K-1 (16 bits in VAS_LRX_WCRED)
*
* TODO: Needs tuning for per-process credits
*/
-#define VAS_RX_WCREDS_MAX ((64 << 10) - 1)
#define VAS_TX_WCREDS_MAX ((4 << 10) - 1)
#define VAS_WCREDS_DEFAULT (1 << 10)
--
1.8.3.1
next prev parent reply other threads:[~2020-04-01 21:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 21:19 [PATCH v9 00/13] powerpc/vas: Page fault handling for user space NX requests Haren Myneni
2020-04-01 21:25 ` [PATCH v9 01/13] powerpc/xive: Define xive_native_alloc_irq_on_chip() Haren Myneni
2020-04-01 21:25 ` [PATCH v9 02/13] powerpc/vas: Define nx_fault_stamp in coprocessor_request_block Haren Myneni
2020-04-01 21:26 ` [PATCH v9 03/13] powerpc/vas: Alloc and setup IRQ and trigger port address Haren Myneni
2020-04-01 21:26 ` [PATCH v9 04/13] powerpc/vas: Setup fault window per VAS instance Haren Myneni
2020-04-01 21:27 ` [PATCH v9 05/13] powerpc/vas: Register NX with fault window ID and IRQ port value Haren Myneni
2020-04-01 21:28 ` [PATCH 06/13] powerpc/vas: Take reference to PID and mm for user space windows Haren Myneni
2020-04-01 22:13 ` [PATCH v9 " Haren Myneni
2020-04-01 21:28 ` [PATCH v9 07/13] powerpc/vas: Setup thread IRQ handler per VAS instance Haren Myneni
2020-04-01 21:29 ` [PATCH v9 08/13] powerpc/vas: Update CSB and notify process for fault CRBs Haren Myneni
2020-04-01 21:29 ` [PATCH v9 09/13] powerpc/vas: Return credits after handling fault Haren Myneni
2020-04-01 21:30 ` [PATCH v9 10/13] powerpc/vas: Print CRB and FIFO values Haren Myneni
2020-04-01 21:31 ` Haren Myneni [this message]
2020-04-01 21:31 ` [PATCH v9 12/13] powerpc/vas: Display process stuck message Haren Myneni
2020-04-01 21:32 ` [PATCH v9 13/13] powerpc/vas: Free send window in VAS instance after credits returned Haren Myneni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1585776666.10664.455.camel@hbabu-laptop \
--to=haren@linux.ibm.com \
--cc=ajd@linux.ibm.com \
--cc=clg@kaod.org \
--cc=frederic.barrat@fr.ibm.com \
--cc=hch@infradead.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=oohall@gmail.com \
--cc=srikar@linux.vnet.ibm.com \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).