From: Michal Hocko <mhocko@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Joel Fernandes <joel@joelfernandes.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Neil Brown <neilb@suse.de>, <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Michal Hocko <mhocko@suse.com>
Subject: [PATCH 1/2] mm: clarify __GFP_MEMALLOC usage
Date: Fri, 3 Apr 2020 10:35:42 +0200 [thread overview]
Message-ID: <20200403083543.11552-2-mhocko@kernel.org> (raw)
In-Reply-To: <20200403083543.11552-1-mhocko@kernel.org>
From: Michal Hocko <mhocko@suse.com>
It seems that the existing documentation is not explicit about the
expected usage and potential risks enough. While it is calls out
that users have to free memory when using this flag it is not really
apparent that users have to careful to not deplete memory reserves
and that they should implement some sort of throttling wrt. freeing
process.
This is partly based on Neil's explanation [1].
[1] http://lkml.kernel.org/r/877dz0yxoa.fsf@notabene.neil.brown.name
Signed-off-by: Michal Hocko <mhocko@suse.com>
---
include/linux/gfp.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/linux/gfp.h b/include/linux/gfp.h
index e5b817cb86e7..e3ab1c0d9140 100644
--- a/include/linux/gfp.h
+++ b/include/linux/gfp.h
@@ -110,6 +110,9 @@ struct vm_area_struct;
* the caller guarantees the allocation will allow more memory to be freed
* very shortly e.g. process exiting or swapping. Users either should
* be the MM or co-ordinating closely with the VM (e.g. swap over NFS).
+ * Users of this flag have to be extremely careful to not deplete the reserve
+ * completely and implement a throttling mechanism which controls the consumption
+ * of the reserve based on the amount of freed memory.
*
* %__GFP_NOMEMALLOC is used to explicitly forbid access to emergency reserves.
* This takes precedence over the %__GFP_MEMALLOC flag if both are set.
--
2.25.1
next prev parent reply other threads:[~2020-04-03 8:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 8:35 [PATCH 0/2] mm: few refinements to gfp flags documentation Michal Hocko
2020-04-03 8:35 ` Michal Hocko [this message]
2020-04-03 19:41 ` [PATCH 1/2] mm: clarify __GFP_MEMALLOC usage David Rientjes
2020-04-03 21:23 ` NeilBrown
2020-04-06 7:01 ` Michal Hocko
2020-04-06 19:02 ` John Hubbard
2020-04-06 23:32 ` David Rientjes
2020-04-06 23:40 ` John Hubbard
2020-04-14 2:15 ` Andrew Morton
2020-04-14 3:56 ` NeilBrown
2020-04-14 19:05 ` John Hubbard
2020-04-07 1:00 ` NeilBrown
2020-04-07 1:21 ` John Hubbard
2020-04-07 7:24 ` Michal Hocko
2020-04-03 8:35 ` [PATCH 2/2] mm: make it clear that gfp reclaim modifiers are valid only for sleepable allocations Michal Hocko
2020-04-03 19:41 ` David Rientjes
2020-04-07 1:38 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200403083543.11552-2-mhocko@kernel.org \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=neilb@suse.de \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).