regulator: use consumer->supply_name in debugfs/regulator_summary
diff mbox series

Message ID 731a4b299c6ae0ee9d8995157600a3477f21a36c.1585959068.git.mirq-linux@rere.qmqm.pl
State Accepted
Commit 6b576eb035dba77daf091f045fa1448682ee12b4
Headers show
Series
  • regulator: use consumer->supply_name in debugfs/regulator_summary
Related show

Commit Message

Michał Mirosław April 4, 2020, 12:11 a.m. UTC
Make it easier to identify regulator consumers when consumer device
uses more than one supply.

Before:

  regulator                      ena use open bypass voltage current min     max
 -----------------------------------------------------------------------------------
  regulator-dummy                  1   0    2      0     0mV     0mA 0mV     0mV
     1-0010                                                          0mV     0mV
     1-0010                                                          0mV     0mV

After:

  regulator                      ena use open bypass voltage current min     max
 -----------------------------------------------------------------------------------
  regulator-dummy                  1   0    2      0     0mV     0mA 0mV     0mV
     1-0010-vccio                                                    0mV     0mV
     1-0010-vcc33                                                    0mV     0mV

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
---
 drivers/regulator/core.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Dmitry Osipenko April 15, 2020, 4:28 p.m. UTC | #1
04.04.2020 03:11, Michał Mirosław пишет:
> Make it easier to identify regulator consumers when consumer device
> uses more than one supply.
> 
> Before:
> 
>   regulator                      ena use open bypass voltage current min     max
>  -----------------------------------------------------------------------------------
>   regulator-dummy                  1   0    2      0     0mV     0mA 0mV     0mV
>      1-0010                                                          0mV     0mV
>      1-0010                                                          0mV     0mV
> 
> After:
> 
>   regulator                      ena use open bypass voltage current min     max
>  -----------------------------------------------------------------------------------
>   regulator-dummy                  1   0    2      0     0mV     0mA 0mV     0mV
>      1-0010-vccio                                                    0mV     0mV
>      1-0010-vcc33                                                    0mV     0mV
> 
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> ---
>  drivers/regulator/core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index c340505150b6..ad143004c32b 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -5496,6 +5496,7 @@ static void regulator_summary_show_subtree(struct seq_file *s,
>  		seq_printf(s, "%*s%-*s ",
>  			   (level + 1) * 3 + 1, "",
>  			   30 - (level + 1) * 3,
> +			   consumer->supply_name ? consumer->supply_name :
>  			   consumer->dev ? dev_name(consumer->dev) : "deviceless");
>  
>  		switch (rdev->desc->type) {
> 

Hello Michał,

This is a very nice improvement, I like it!

Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
Tested-by: Dmitry Osipenko <digetx@gmail.com>

Patch
diff mbox series

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index c340505150b6..ad143004c32b 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -5496,6 +5496,7 @@  static void regulator_summary_show_subtree(struct seq_file *s,
 		seq_printf(s, "%*s%-*s ",
 			   (level + 1) * 3 + 1, "",
 			   30 - (level + 1) * 3,
+			   consumer->supply_name ? consumer->supply_name :
 			   consumer->dev ? dev_name(consumer->dev) : "deviceless");
 
 		switch (rdev->desc->type) {