From: Markus Elfring <Markus.Elfring@web.de>
To: linux-gpio@vger.kernel.org, Andy Shevchenko <andy@kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Linus Walleij <linus.walleij@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Tang Bin <tangbin@cmss.chinamobile.com>
Subject: [PATCH] gpio: msic: Delete an error message in platform_msic_gpio_probe()
Date: Sat, 4 Apr 2020 21:35:24 +0200 [thread overview]
Message-ID: <bb60007c-585f-052d-2f86-5598ff7619cd@web.de> (raw)
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 4 Apr 2020 21:30:12 +0200
The function “platform_get_irq” can log an error already.
Thus omit a redundant message for the exception handling in the
calling function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/gpio/gpio-msic.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpio/gpio-msic.c b/drivers/gpio/gpio-msic.c
index 7e3c96e4ab2c..5548b7be36b3 100644
--- a/drivers/gpio/gpio-msic.c
+++ b/drivers/gpio/gpio-msic.c
@@ -248,10 +248,8 @@ static int platform_msic_gpio_probe(struct platform_device *pdev)
int retval;
int i;
- if (irq < 0) {
- dev_err(dev, "no IRQ line: %d\n", irq);
+ if (irq < 0)
return irq;
- }
if (!pdata || !pdata->gpio_base) {
dev_err(dev, "incorrect or missing platform data\n");
--
2.26.0
next reply other threads:[~2020-04-04 19:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-04 19:35 Markus Elfring [this message]
2020-04-05 10:43 ` [PATCH] gpio: msic: Delete an error message in platform_msic_gpio_probe() Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb60007c-585f-052d-2f86-5598ff7619cd@web.de \
--to=markus.elfring@web.de \
--cc=andy@kernel.org \
--cc=bgolaszewski@baylibre.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tangbin@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).