linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Ard Biesheuvel <ardb@kernel.org>,
	"richard.henderson@linaro.org" <richard.henderson@linaro.org>,
	"christophe.lyon@st.com" <christophe.lyon@st.com>,
	kbuild test robot <lkp@intel.com>,
	"daniel.santos@pobox.com" <daniel.santos@pobox.com>,
	Jason Wang <jasowang@redhat.com>,
	"kbuild-all@lists.01.org" <kbuild-all@lists.01.org>,
	Russell King <rmk+kernel@armlinux.org.uk>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	virtualization@lists.linux-foundation.org
Subject: [PATCH v2 1/2] vdpa-sim: depend on HAS_DMA
Date: Mon, 6 Apr 2020 08:12:42 -0400	[thread overview]
Message-ID: <20200406121233.109889-2-mst@redhat.com> (raw)
In-Reply-To: <20200406121233.109889-1-mst@redhat.com>

set_dma_ops isn't available on all architectures:

        make ARCH=um
...

   drivers/vdpa/vdpa_sim/vdpa_sim.c: In function 'vdpasim_create':
>> drivers/vdpa/vdpa_sim/vdpa_sim.c:324:2: error: implicit declaration of function 'set_dma_ops'; did you mean 'set_groups'?
+[-Werror=implicit-function-declaration]
     set_dma_ops(dev, &vdpasim_dma_ops);
     ^~~~~~~~~~~
     set_groups

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 drivers/vdpa/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/vdpa/Kconfig b/drivers/vdpa/Kconfig
index 08b615f2da39..d0cb0e583a5d 100644
--- a/drivers/vdpa/Kconfig
+++ b/drivers/vdpa/Kconfig
@@ -14,7 +14,7 @@ if VDPA_MENU
 
 config VDPA_SIM
 	tristate "vDPA device simulator"
-	depends on RUNTIME_TESTING_MENU
+	depends on RUNTIME_TESTING_MENU && HAS_DMA
 	select VDPA
 	select VHOST_RING
 	select VHOST_IOTLB
-- 
MST


  reply	other threads:[~2020-04-06 12:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-06 12:12 [PATCH v2 0/2] vhost: add kconfig dependencies Michael S. Tsirkin
2020-04-06 12:12 ` Michael S. Tsirkin [this message]
2020-04-06 12:12 ` [PATCH v2 2/2] vhost: disable for OABI Michael S. Tsirkin
2020-04-06 12:45   ` Ard Biesheuvel
2020-04-06 12:56     ` Michael S. Tsirkin
2020-04-06 12:50   ` Arnd Bergmann
2020-04-06 13:02     ` Michael S. Tsirkin
2020-04-06 13:15       ` Arnd Bergmann
2020-04-06 13:21         ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200406121233.109889-2-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=ardb@kernel.org \
    --cc=christophe.lyon@st.com \
    --cc=daniel.santos@pobox.com \
    --cc=jasowang@redhat.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=richard.henderson@linaro.org \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).