linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org,
	x86@kernel.org, arnd@arndb.de,
	srinivas.pandruvada@linux.intel.com, bberg@redhat.com,
	bp@suse.de
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>
Subject: [PATCH 3/3] x86/mce/therm_throt: allow disabling the thermal vector altogether
Date: Tue,  7 Apr 2020 00:33:45 -0600	[thread overview]
Message-ID: <20200407063345.4484-3-Jason@zx2c4.com> (raw)
In-Reply-To: <20200407063345.4484-1-Jason@zx2c4.com>

The thermal IRQ handler uses 1.21% CPU on my system when it's hot from
compiling things. Indeed looking at /proc/interrupts reveals quite a lot
of events coming in. Beyond logging them, the existing drivers on the
system don't appear to do very much that I'm interested in. So, add a
way to disable this entirely so that I can regain precious CPU cycles.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---
 arch/x86/Kconfig                | 4 ++++
 arch/x86/kernel/cpu/mce/intel.c | 3 ++-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 39e7444353af..3125a11932f2 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -1157,7 +1157,11 @@ config X86_MCE_INJECT
 
 config X86_THERMAL_VECTOR
 	def_bool y
+	prompt "Machine check thermal vector"
 	depends on X86_MCE_INTEL
+	---help---
+	  Provide support for capturing thermal events, logging them, and
+	  passing them off to other drivers.
 
 config X86_MCE_THERMAL_VERBOSE
 	bool "Verbose logging for thermal events"
diff --git a/arch/x86/kernel/cpu/mce/intel.c b/arch/x86/kernel/cpu/mce/intel.c
index f996ffb887bc..d14f1922fb49 100644
--- a/arch/x86/kernel/cpu/mce/intel.c
+++ b/arch/x86/kernel/cpu/mce/intel.c
@@ -511,7 +511,8 @@ static void intel_ppin_init(struct cpuinfo_x86 *c)
 
 void mce_intel_feature_init(struct cpuinfo_x86 *c)
 {
-	intel_init_thermal(c);
+	if (IS_ENABLED(CONFIG_X86_THERMAL_VECTOR))
+		intel_init_thermal(c);
 	intel_init_cmci();
 	intel_init_lmce();
 	intel_ppin_init(c);
-- 
2.26.0


  parent reply	other threads:[~2020-04-07  6:34 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-07  6:33 [PATCH 1/3] x86/mce/therm_throt: remove unused platform_thermal_notify function pointer Jason A. Donenfeld
2020-04-07  6:33 ` [PATCH 2/3] x86/mce/therm_throt: allow disabling verbose logging Jason A. Donenfeld
2020-04-07  6:33 ` Jason A. Donenfeld [this message]
2020-04-14  3:38   ` [PATCH 3/3] x86/mce/therm_throt: allow disabling the thermal vector altogether Srinivas Pandruvada
2020-04-14  4:21     ` Jason A. Donenfeld
2020-04-14 14:45       ` Srinivas Pandruvada
2020-04-14 19:41         ` Jason A. Donenfeld
2020-04-14 19:58           ` Srinivas Pandruvada
2020-04-14 20:09             ` Jason A. Donenfeld
2020-04-14 20:23           ` Borislav Petkov
2020-04-14 20:49             ` Srinivas Pandruvada
2020-04-14 21:07               ` Jason A. Donenfeld
2020-04-14 21:51                 ` Srinivas Pandruvada
2020-04-14 21:40   ` Peter Zijlstra
2020-04-14 21:44     ` Srinivas Pandruvada
2020-04-13 21:09 ` [PATCH 1/3] x86/mce/therm_throt: remove unused platform_thermal_notify function pointer Jason A. Donenfeld
2020-04-14  3:55 ` Srinivas Pandruvada
2020-04-14  4:21   ` Jason A. Donenfeld
2020-04-14 14:49     ` Srinivas Pandruvada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200407063345.4484-3-Jason@zx2c4.com \
    --to=jason@zx2c4.com \
    --cc=arnd@arndb.de \
    --cc=bberg@redhat.com \
    --cc=bp@suse.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).