From: Niklas Schnelle <schnelle@linux.ibm.com>
To: Saeed Mahameed <saeedm@mellanox.com>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, Leon Romanovsky <leon@kernel.org>,
Eran Ben Elisha <eranbe@mellanox.com>,
Moshe Shemesh <moshe@mellanox.com>,
Niklas Schnelle <schnelle@linux.ibm.com>
Subject: [RFC 1/1] net/mlx5: Fix failing fw tracer allocation on s390
Date: Tue, 7 Apr 2020 10:01:30 +0200 [thread overview]
Message-ID: <20200407080130.34472-2-schnelle@linux.ibm.com> (raw)
In-Reply-To: <20200407080130.34472-1-schnelle@linux.ibm.com>
On s390 FORCE_MAX_ZONEORDER is 9 instead of 11, thus a larger kzalloc()
allocation as done for the firmware tracer will always fail.
Looking at mlx5_fw_tracer_save_trace(), it is actually the driver itself
that copies the debug data into the trace array and there is no need for
the allocation to be contiguous in physical memory. We can therefor use
kvzalloc() instead of kzalloc() and get rid of the large contiguous
allcoation.
Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
---
drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c b/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c
index c9c9b479bda5..5ce6ebbc7f10 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c
@@ -935,7 +935,7 @@ struct mlx5_fw_tracer *mlx5_fw_tracer_create(struct mlx5_core_dev *dev)
return NULL;
}
- tracer = kzalloc(sizeof(*tracer), GFP_KERNEL);
+ tracer = kvzalloc(sizeof(*tracer), GFP_KERNEL);
if (!tracer)
return ERR_PTR(-ENOMEM);
@@ -982,7 +982,7 @@ struct mlx5_fw_tracer *mlx5_fw_tracer_create(struct mlx5_core_dev *dev)
tracer->dev = NULL;
destroy_workqueue(tracer->work_queue);
free_tracer:
- kfree(tracer);
+ kvfree(tracer);
return ERR_PTR(err);
}
@@ -1061,7 +1061,7 @@ void mlx5_fw_tracer_destroy(struct mlx5_fw_tracer *tracer)
mlx5_fw_tracer_destroy_log_buf(tracer);
flush_workqueue(tracer->work_queue);
destroy_workqueue(tracer->work_queue);
- kfree(tracer);
+ kvfree(tracer);
}
static int fw_tracer_event(struct notifier_block *nb, unsigned long action, void *data)
--
2.17.1
next prev parent reply other threads:[~2020-04-07 8:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 8:01 [RFC 0/1] net/mlx5: Failing fw tracer allocation on s390 Niklas Schnelle
2020-04-07 8:01 ` Niklas Schnelle [this message]
2020-04-08 19:36 ` [RFC 1/1] net/mlx5: Fix failing " Saeed Mahameed
-- strict thread matches above, loose matches on Subject: below --
2020-03-18 16:44 [RFC 0/1] net/mlx5: Failing " Niklas Schnelle
2020-03-18 16:44 ` [RFC 1/1] net/mlx5: Fix failing " Niklas Schnelle
2020-03-18 17:13 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200407080130.34472-2-schnelle@linux.ibm.com \
--to=schnelle@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=eranbe@mellanox.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=moshe@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).