From: ira.weiny@intel.com
To: linux-kernel@vger.kernel.org
Cc: Ira Weiny <ira.weiny@intel.com>,
Dave Chinner <dchinner@redhat.com>, Jan Kara <jack@suse.cz>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Dan Williams <dan.j.williams@intel.com>,
Dave Chinner <david@fromorbit.com>,
Christoph Hellwig <hch@lst.de>,
"Theodore Y. Ts'o" <tytso@mit.edu>,
Jeff Moyer <jmoyer@redhat.com>,
linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: [PATCH V6 2/8] fs: Remove unneeded IS_DAX() check
Date: Tue, 7 Apr 2020 11:29:52 -0700 [thread overview]
Message-ID: <20200407182958.568475-3-ira.weiny@intel.com> (raw)
In-Reply-To: <20200407182958.568475-1-ira.weiny@intel.com>
From: Ira Weiny <ira.weiny@intel.com>
Remove the check because DAX now has it's own read/write methods and
file systems which support DAX check IS_DAX() prior to IOCB_DIRECT on
their own. Therefore, it does not matter if the file state is DAX when
the iocb flags are created.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Ira Weiny <ira.weiny@intel.com>
---
Changes from v3:
Reword commit message.
Reordered to be a 'pre-cleanup' patch
---
include/linux/fs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/fs.h b/include/linux/fs.h
index abedbffe2c9e..f97b99c36cee 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -3389,7 +3389,7 @@ extern int file_update_time(struct file *file);
static inline bool io_is_direct(struct file *filp)
{
- return (filp->f_flags & O_DIRECT) || IS_DAX(filp->f_mapping->host);
+ return (filp->f_flags & O_DIRECT);
}
static inline bool vma_is_dax(struct vm_area_struct *vma)
--
2.25.1
next prev parent reply other threads:[~2020-04-07 18:30 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 18:29 [PATCH V6 0/8] Enable per-file/per-directory DAX operations V6 ira.weiny
2020-04-07 18:29 ` [PATCH V6 1/8] fs/xfs: Remove unnecessary initialization of i_rwsem ira.weiny
2020-04-07 23:46 ` Dave Chinner
2020-04-07 18:29 ` ira.weiny [this message]
2020-04-09 7:31 ` [PATCH V6 2/8] fs: Remove unneeded IS_DAX() check Christoph Hellwig
2020-04-09 14:57 ` Ira Weiny
2020-04-07 18:29 ` [PATCH V6 3/8] fs/stat: Define DAX statx attribute ira.weiny
2020-04-07 23:47 ` Dave Chinner
2020-04-07 18:29 ` [PATCH V6 4/8] fs/xfs: Make DAX mount option a tri-state ira.weiny
2020-04-07 23:59 ` Dave Chinner
2020-04-08 0:09 ` Ira Weiny
2020-04-08 0:48 ` Dave Chinner
2020-04-09 15:03 ` Ira Weiny
2020-04-07 18:29 ` [PATCH V6 5/8] fs/xfs: Create function xfs_inode_enable_dax() ira.weiny
2020-04-08 0:05 ` Dave Chinner
2020-04-08 0:13 ` Ira Weiny
2020-04-07 18:29 ` [PATCH V6 6/8] fs/xfs: Combine xfs_diflags_to_linux() and xfs_diflags_to_iflags() ira.weiny
2020-04-08 2:08 ` Dave Chinner
2020-04-08 17:09 ` Ira Weiny
2020-04-08 21:02 ` Dave Chinner
2020-04-08 21:28 ` Dan Williams
2020-04-08 22:10 ` Ira Weiny
2020-04-08 23:58 ` Dave Chinner
2020-04-09 0:22 ` Ira Weiny
2020-04-09 12:41 ` Christoph Hellwig
2020-04-09 20:49 ` Ira Weiny
2020-04-08 22:07 ` Ira Weiny
2020-04-08 23:21 ` Dave Chinner
2020-04-09 0:12 ` Ira Weiny
2020-04-09 0:30 ` Darrick J. Wong
2020-04-09 15:29 ` Ira Weiny
2020-04-09 16:59 ` Darrick J. Wong
2020-04-09 17:17 ` Jan Kara
2020-04-09 20:54 ` Ira Weiny
2020-04-09 0:49 ` Dave Chinner
2020-04-09 12:40 ` Christoph Hellwig
2020-04-10 0:27 ` Dave Chinner
2020-04-07 18:29 ` [PATCH V6 7/8] fs/xfs: Change xfs_ioctl_setattr_dax_invalidate() to xfs_ioctl_dax_check() ira.weiny
2020-04-08 2:23 ` Dave Chinner
2020-04-08 9:58 ` Jan Kara
2020-04-08 21:09 ` Dave Chinner
2020-04-08 22:26 ` Ira Weiny
2020-04-08 23:48 ` Dave Chinner
2020-04-09 12:28 ` Christoph Hellwig
2020-04-08 15:37 ` Darrick J. Wong
2020-04-08 18:13 ` Ira Weiny
2020-04-16 5:39 ` [fs/xfs] 857c9841f8: xfstests.xfs.046.fail kernel test robot
2020-04-07 18:29 ` [PATCH V6 8/8] Documentation/dax: Update Usage section ira.weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200407182958.568475-3-ira.weiny@intel.com \
--to=ira.weiny@intel.com \
--cc=dan.j.williams@intel.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=dchinner@redhat.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jmoyer@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).