From: Peter Xu <peterx@redhat.com>
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: Nitesh Narayan Lal <nitesh@redhat.com>,
peterx@redhat.com, Andrew Morton <akpm@linux-foundation.org>,
Mike Kravetz <mike.kravetz@oracle.com>
Subject: [PATCH] Documentation: hugetlb: Update hugetlb options
Date: Thu, 9 Apr 2020 17:58:00 -0400 [thread overview]
Message-ID: <20200409215800.8967-1-peterx@redhat.com> (raw)
The hugepage options are not documented clearly.
Firstly, default_hugepagesz= should always be specified after the
declaration of the same type of huge page using hugepagesz=. For
example, if we boot a x86_64 system with kernel cmdline
"default_hugepagesz=2M", we'll get a very funny error message:
"HugeTLB: unsupported default_hugepagesz 2097152. Reverting to 2097152"
It's understandable from code-wise because when hugetlb_init() we
didn't have the 2M page hstate registered, so it's unsupported.
However 2M is actually the default huge page size on x86_64, so we'll
register it right after the error message. However it's very
confusing if without these knowledges.
Secondly, hugepages= option must be used _after_ another hugepagesz=.
The word "interleave" is fine but it didn't declare the fact that
each of the hugepages= option will be applied to the previous parsed
hugepagesz= option.
State all these clear.
Signed-off-by: Peter Xu <peterx@redhat.com>
---
.../admin-guide/kernel-parameters.txt | 19 ++++++++++++-------
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
index 86aae1fa099a..2a77b2b01e5e 100644
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -839,7 +839,8 @@
the legacy /proc/ hugepages APIs, used for SHM, and
default size when mounting hugetlbfs filesystems.
Defaults to the default architecture's huge page size
- if not specified.
+ if not specified. This option can only be used with a
+ pre-defined "hugepagesz=" of the same size.
deferred_probe_timeout=
[KNL] Debugging option to set a timeout in seconds for
@@ -1475,13 +1476,17 @@
hpet_mmap= [X86, HPET_MMAP] Allow userspace to mmap HPET
registers. Default set by CONFIG_HPET_MMAP_DEFAULT.
+ hugepagesz= [HW,IA-64,PPC,X86-64] Declare one type of HugeTLB pages
+ with the size specified. Valid pages sizes on x86-64
+ are 2M (when the CPU supports "pse") and 1G (when the
+ CPU supports the "pdpe1gb" cpuinfo flag).
+
hugepages= [HW,X86-32,IA-64] HugeTLB pages to allocate at boot.
- hugepagesz= [HW,IA-64,PPC,X86-64] The size of the HugeTLB pages.
- On x86-64 and powerpc, this option can be specified
- multiple times interleaved with hugepages= to reserve
- huge pages of different sizes. Valid pages sizes on
- x86-64 are 2M (when the CPU supports "pse") and 1G
- (when the CPU supports the "pdpe1gb" cpuinfo flag).
+ On x86-64 and powerpc, this option must be used after
+ one hugepagesz= to allocate huge pages of that specific
+ size. This option can also be used multiple times
+ pairing with hugepagesz= to allocate huge pages for
+ different sizes.
hung_task_panic=
[KNL] Should the hung task detector generate panics.
--
2.24.1
next reply other threads:[~2020-04-09 21:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 21:58 Peter Xu [this message]
2020-04-09 22:08 ` [PATCH] Documentation: hugetlb: Update hugetlb options Mike Kravetz
2020-04-09 22:18 ` Peter Xu
2020-04-10 12:02 ` Nitesh Narayan Lal
2020-04-10 11:57 ` Nitesh Narayan Lal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200409215800.8967-1-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=nitesh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).