From: ira.weiny@intel.com
To: linux-kernel@vger.kernel.org,
"Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Ira Weiny <ira.weiny@intel.com>,
Dave Chinner <dchinner@redhat.com>, Jan Kara <jack@suse.cz>,
Dan Williams <dan.j.williams@intel.com>,
Dave Chinner <david@fromorbit.com>,
Christoph Hellwig <hch@lst.de>,
"Theodore Y. Ts'o" <tytso@mit.edu>,
Jeff Moyer <jmoyer@redhat.com>,
linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: [PATCH V7 3/9] fs/stat: Define DAX statx attribute
Date: Sun, 12 Apr 2020 22:40:40 -0700 [thread overview]
Message-ID: <20200413054046.1560106-4-ira.weiny@intel.com> (raw)
In-Reply-To: <20200413054046.1560106-1-ira.weiny@intel.com>
From: Ira Weiny <ira.weiny@intel.com>
In order for users to determine if a file is currently operating in DAX
state (effective DAX). Define a statx attribute value and set that
attribute if the effective DAX flag is set.
To go along with this we propose the following addition to the statx man
page:
STATX_ATTR_DAX
The file is in the DAX (cpu direct access) state. DAX state
attempts to minimize software cache effects for both I/O and
memory mappings of this file. It requires a file system which
has been configured to support DAX.
DAX generally assumes all accesses are via cpu load / store
instructions which can minimize overhead for small accesses, but
may adversely affect cpu utilization for large transfers.
File I/O is done directly to/from user-space buffers and memory
mapped I/O may be performed with direct memory mappings that
bypass kernel page cache.
While the DAX property tends to result in data being transferred
synchronously, it does not give the same guarantees of O_SYNC
where data and the necessary metadata are transferred together.
A DAX file may support being mapped with the MAP_SYNC flag,
which enables a program to use CPU cache flush instructions to
persist CPU store operations without an explicit fsync(2). See
mmap(2) for more information.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Ira Weiny <ira.weiny@intel.com>
---
Changes from V2:
Update man page text with comments from Darrick, Jan, Dan, and
Dave.
---
fs/stat.c | 3 +++
include/uapi/linux/stat.h | 1 +
2 files changed, 4 insertions(+)
diff --git a/fs/stat.c b/fs/stat.c
index 030008796479..894699c74dde 100644
--- a/fs/stat.c
+++ b/fs/stat.c
@@ -79,6 +79,9 @@ int vfs_getattr_nosec(const struct path *path, struct kstat *stat,
if (IS_AUTOMOUNT(inode))
stat->attributes |= STATX_ATTR_AUTOMOUNT;
+ if (IS_DAX(inode))
+ stat->attributes |= STATX_ATTR_DAX;
+
if (inode->i_op->getattr)
return inode->i_op->getattr(path, stat, request_mask,
query_flags);
diff --git a/include/uapi/linux/stat.h b/include/uapi/linux/stat.h
index ad80a5c885d5..e5f9d5517f6b 100644
--- a/include/uapi/linux/stat.h
+++ b/include/uapi/linux/stat.h
@@ -169,6 +169,7 @@ struct statx {
#define STATX_ATTR_ENCRYPTED 0x00000800 /* [I] File requires key to decrypt in fs */
#define STATX_ATTR_AUTOMOUNT 0x00001000 /* Dir: Automount trigger */
#define STATX_ATTR_VERITY 0x00100000 /* [I] Verity protected file */
+#define STATX_ATTR_DAX 0x00002000 /* [I] File is DAX */
#endif /* _UAPI_LINUX_STAT_H */
--
2.25.1
next prev parent reply other threads:[~2020-04-13 5:41 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 5:40 [PATCH V7 0/9] Enable per-file/per-directory DAX operations V7 ira.weiny
2020-04-13 5:40 ` [PATCH V7 1/9] fs/xfs: Remove unnecessary initialization of i_rwsem ira.weiny
2020-04-13 15:41 ` Darrick J. Wong
2020-04-13 5:40 ` [PATCH V7 2/9] fs: Remove unneeded IS_DAX() check in io_is_direct() ira.weiny
2020-04-14 6:22 ` Christoph Hellwig
2020-04-13 5:40 ` ira.weiny [this message]
2020-04-14 6:23 ` [PATCH V7 3/9] fs/stat: Define DAX statx attribute Christoph Hellwig
2020-04-14 20:39 ` Ira Weiny
2020-04-13 5:40 ` [PATCH V7 4/9] fs/xfs: Make DAX mount option a tri-state ira.weiny
2020-04-13 15:46 ` Darrick J. Wong
2020-04-13 19:28 ` Ira Weiny
2020-04-14 6:24 ` Christoph Hellwig
2020-04-14 6:25 ` Christoph Hellwig
2020-04-14 20:34 ` Ira Weiny
2020-04-13 5:40 ` [PATCH V7 5/9] fs/xfs: Create function xfs_inode_enable_dax() ira.weiny
2020-04-13 15:52 ` Darrick J. Wong
2020-04-13 19:39 ` Ira Weiny
2020-04-14 6:27 ` Christoph Hellwig
2020-04-14 20:43 ` Ira Weiny
2020-04-13 5:40 ` [PATCH V7 6/9] fs/xfs: Combine xfs_diflags_to_linux() and xfs_diflags_to_iflags() ira.weiny
2020-04-13 16:01 ` Darrick J. Wong
2020-04-14 4:07 ` Ira Weiny
2020-04-13 5:40 ` [PATCH V7 7/9] fs: Define I_DONTCACNE in VFS layer ira.weiny
2020-04-13 16:09 ` Darrick J. Wong
2020-04-13 16:13 ` Darrick J. Wong
2020-04-13 19:44 ` Ira Weiny
2020-04-14 15:26 ` Jan Kara
2020-04-14 15:45 ` Ira Weiny
2020-04-14 15:59 ` Jan Kara
2020-04-13 5:40 ` [PATCH V7 8/9] fs/xfs: Change xfs_ioctl_setattr_dax_invalidate() ira.weiny
2020-04-13 16:12 ` Darrick J. Wong
2020-04-13 19:46 ` Ira Weiny
2020-04-13 5:40 ` [PATCH V7 9/9] Documentation/dax: Update Usage section ira.weiny
2020-04-13 16:19 ` Darrick J. Wong
2020-04-14 4:38 ` Ira Weiny
2020-04-14 5:12 ` Dan Williams
2020-04-14 19:48 ` Ira Weiny
2020-04-15 8:23 ` Jan Kara
2020-04-14 5:21 ` Dan Williams
2020-04-14 16:15 ` Darrick J. Wong
2020-04-14 19:04 ` Dan Williams
2020-04-14 19:57 ` Darrick J. Wong
2020-04-14 20:00 ` Ira Weiny
2020-04-14 20:18 ` Darrick J. Wong
2020-04-14 20:54 ` Ira Weiny
2020-04-14 21:02 ` Darrick J. Wong
2020-04-14 19:58 ` Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200413054046.1560106-4-ira.weiny@intel.com \
--to=ira.weiny@intel.com \
--cc=dan.j.williams@intel.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=dchinner@redhat.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jmoyer@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).