From: Leon Romanovsky <leon@kernel.org>
To: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: Leon Romanovsky <leonro@mellanox.com>,
Borislav Petkov <bp@suse.de>, Jessica Yu <jeyu@kernel.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH net-next 4/4] kernel/module: Hide vermagic header file from general use
Date: Tue, 14 Apr 2020 18:57:32 +0300 [thread overview]
Message-ID: <20200414155732.1236944-5-leon@kernel.org> (raw)
In-Reply-To: <20200414155732.1236944-1-leon@kernel.org>
From: Leon Romanovsky <leonro@mellanox.com>
VERMAGIC* definitions are not supposed to be used by the drivers,
see this [1] bug report, so simply move this header file to be visible
to kernel/* files only.
[1] https://lore.kernel.org/lkml/20200411155623.GA22175@zn.tnic
Reported-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
---
kernel/module.c | 2 +-
{include/linux => kernel}/vermagic.h | 0
2 files changed, 1 insertion(+), 1 deletion(-)
rename {include/linux => kernel}/vermagic.h (100%)
diff --git a/kernel/module.c b/kernel/module.c
index 3447f3b74870..fce06095d341 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -29,7 +29,6 @@
#include <linux/moduleparam.h>
#include <linux/errno.h>
#include <linux/err.h>
-#include <linux/vermagic.h>
#include <linux/notifier.h>
#include <linux/sched.h>
#include <linux/device.h>
@@ -55,6 +54,7 @@
#include <linux/audit.h>
#include <uapi/linux/module.h>
#include "module-internal.h"
+#include "vermagic.h"
#define CREATE_TRACE_POINTS
#include <trace/events/module.h>
diff --git a/include/linux/vermagic.h b/kernel/vermagic.h
similarity index 100%
rename from include/linux/vermagic.h
rename to kernel/vermagic.h
--
2.25.2
next prev parent reply other threads:[~2020-04-14 15:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 15:57 [PATCH net-next 0/4] Remove vermagic header from global include folder Leon Romanovsky
2020-04-14 15:57 ` Leon Romanovsky [this message]
2020-04-14 16:03 ` [PATCH net-next 4/4] kernel/module: Hide vermagic header file from general use Borislav Petkov
2020-04-14 18:41 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414155732.1236944-5-leon@kernel.org \
--to=leon@kernel.org \
--cc=bp@suse.de \
--cc=davem@davemloft.net \
--cc=jeyu@kernel.org \
--cc=kuba@kernel.org \
--cc=leonro@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).