ARM: dts: bcm283x: Disable dsi0 node
diff mbox series

Message ID 20200415144233.23274-1-nsaenzjulienne@suse.de
State Accepted
Commit 90444b958461a5f8fc299ece0fe17eab15cba1e1
Headers show
Series
  • ARM: dts: bcm283x: Disable dsi0 node
Related show

Commit Message

Nicolas Saenz Julienne April 15, 2020, 2:42 p.m. UTC
Since its inception the module was meant to be disabled by default, but
the original commit failed to add the relevant property.

Fixes: 4aba4cf82054 ("ARM: dts: bcm2835: Add the DSI module nodes and clocks")
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
---
 arch/arm/boot/dts/bcm283x.dtsi | 1 +
 1 file changed, 1 insertion(+)

Comments

Eric Anholt April 15, 2020, 7:17 p.m. UTC | #1
On Wed, Apr 15, 2020 at 7:42 AM Nicolas Saenz Julienne
<nsaenzjulienne@suse.de> wrote:
>
> Since its inception the module was meant to be disabled by default, but
> the original commit failed to add the relevant property.
>
> Fixes: 4aba4cf82054 ("ARM: dts: bcm2835: Add the DSI module nodes and clocks")
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> ---
>  arch/arm/boot/dts/bcm283x.dtsi | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arch/arm/boot/dts/bcm283x.dtsi
> index e1abe8c730cef..b83a864e2e8ba 100644
> --- a/arch/arm/boot/dts/bcm283x.dtsi
> +++ b/arch/arm/boot/dts/bcm283x.dtsi
> @@ -372,6 +372,7 @@ dsi0: dsi@7e209000 {
>                                              "dsi0_ddr2",
>                                              "dsi0_ddr";
>
> +                       status = "disabled";
>                 };

If you've confirmed that vc4 still probes,

Reviewed-by: Eric Anholt <eric@anholt.net>
Nicolas Saenz Julienne April 16, 2020, 9:36 a.m. UTC | #2
On Wed, 2020-04-15 at 12:17 -0700, Eric Anholt wrote:
> On Wed, Apr 15, 2020 at 7:42 AM Nicolas Saenz Julienne
> <nsaenzjulienne@suse.de> wrote:
> > Since its inception the module was meant to be disabled by default, but
> > the original commit failed to add the relevant property.
> > 
> > Fixes: 4aba4cf82054 ("ARM: dts: bcm2835: Add the DSI module nodes and
> > clocks")
> > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> > ---
> >  arch/arm/boot/dts/bcm283x.dtsi | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arch/arm/boot/dts/bcm283x.dtsi
> > index e1abe8c730cef..b83a864e2e8ba 100644
> > --- a/arch/arm/boot/dts/bcm283x.dtsi
> > +++ b/arch/arm/boot/dts/bcm283x.dtsi
> > @@ -372,6 +372,7 @@ dsi0: dsi@7e209000 {
> >                                              "dsi0_ddr2",
> >                                              "dsi0_ddr";
> > 
> > +                       status = "disabled";
> >                 };
> 
> If you've confirmed that vc4 still probes,

Confirmed.

> Reviewed-by: Eric Anholt <eric@anholt.net>

Thanks,
Nicolas
Florian Fainelli April 16, 2020, 8:58 p.m. UTC | #3
On Wed, 15 Apr 2020 16:42:33 +0200, Nicolas Saenz Julienne <nsaenzjulienne@suse.de> wrote:
> Since its inception the module was meant to be disabled by default, but
> the original commit failed to add the relevant property.
> 
> Fixes: 4aba4cf82054 ("ARM: dts: bcm2835: Add the DSI module nodes and clocks")
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> ---

Applied to devicetree/fixes, thanks!
--
Florian

Patch
diff mbox series

diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arch/arm/boot/dts/bcm283x.dtsi
index e1abe8c730cef..b83a864e2e8ba 100644
--- a/arch/arm/boot/dts/bcm283x.dtsi
+++ b/arch/arm/boot/dts/bcm283x.dtsi
@@ -372,6 +372,7 @@  dsi0: dsi@7e209000 {
 					     "dsi0_ddr2",
 					     "dsi0_ddr";
 
+			status = "disabled";
 		};
 
 		aux: aux@7e215000 {