From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Gregory CLEMENT <gregory.clement@bootlin.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Subject: [PATCH 3/3] iio: adc: ti-ads8344: optimize consumption
Date: Wed, 15 Apr 2020 23:22:57 +0200 [thread overview]
Message-ID: <20200415212257.161238-4-alexandre.belloni@bootlin.com> (raw)
In-Reply-To: <20200415212257.161238-1-alexandre.belloni@bootlin.com>
Set the clock mode only once, at probe time and then keep the ADC powered
down between conversions.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
drivers/iio/adc/ti-ads8344.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/iio/adc/ti-ads8344.c b/drivers/iio/adc/ti-ads8344.c
index 9b2d3a8ea6bd..0804650d8d8a 100644
--- a/drivers/iio/adc/ti-ads8344.c
+++ b/drivers/iio/adc/ti-ads8344.c
@@ -65,7 +65,7 @@ static const struct iio_chan_spec ads8344_channels[] = {
};
static int ads8344_adc_conversion(struct ads8344 *adc, int channel,
- bool differential)
+ bool differential, u8 clock)
{
struct spi_device *spi = adc->spi;
int ret;
@@ -75,7 +75,7 @@ static int ads8344_adc_conversion(struct ads8344 *adc, int channel,
if (!differential)
buf[0] |= ADS8344_SINGLE_END;
buf[0] |= ADS8344_CHANNEL(channel);
- buf[0] |= ADS8344_CLOCK_INTERNAL;
+ buf[0] |= clock;
ret = spi_write(spi, buf, 1);
if (ret)
@@ -100,7 +100,7 @@ static int ads8344_read_raw(struct iio_dev *iio,
case IIO_CHAN_INFO_RAW:
mutex_lock(&adc->lock);
*value = ads8344_adc_conversion(adc, channel->scan_index,
- channel->differential);
+ channel->differential, 0);
mutex_unlock(&adc->lock);
if (*value < 0)
return *value;
@@ -155,6 +155,11 @@ static int ads8344_probe(struct spi_device *spi)
if (ret)
return ret;
+ /* Do a dummy read and set external clock mode */
+ ret = ads8344_adc_conversion(adc, 0, 0, ADS8344_CLOCK_INTERNAL);
+ if (ret < 0)
+ return ret;
+
spi_set_drvdata(spi, indio_dev);
ret = iio_device_register(indio_dev);
--
2.25.2
prev parent reply other threads:[~2020-04-15 21:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 21:22 [PATCH 0/3] iio: adc: ti-ads8344: improve the driver Alexandre Belloni
2020-04-15 21:22 ` [PATCH 1/3] iio: adc: ti-ads8344: properly byte swap value Alexandre Belloni
2020-04-16 6:22 ` kbuild test robot
2020-04-16 20:50 ` Alexandre Belloni
2020-04-19 2:49 ` Philip Li
2020-04-21 7:25 ` Xia, Hui
2020-04-21 12:24 ` Alexandre Belloni
2020-04-16 6:29 ` Lars-Peter Clausen
2020-04-15 21:22 ` [PATCH 2/3] iio: adc: ti-ads8344: remove tx_buf from driver data Alexandre Belloni
2020-04-16 6:26 ` Lars-Peter Clausen
2020-04-17 10:24 ` Andy Shevchenko
2020-04-15 21:22 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200415212257.161238-4-alexandre.belloni@bootlin.com \
--to=alexandre.belloni@bootlin.com \
--cc=gregory.clement@bootlin.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).