dt-bindings: thermal: Convert UniPhier thermal monitor to json-schema
diff mbox series

Message ID 1587013935-21760-1-git-send-email-hayashi.kunihiko@socionext.com
State Superseded
Headers show
Series
  • dt-bindings: thermal: Convert UniPhier thermal monitor to json-schema
Related show

Commit Message

Kunihiko Hayashi April 16, 2020, 5:12 a.m. UTC
Convert the UniPhier thermal monitor binding to DT schema format.

Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
 .../thermal/socionext,uniphier-thermal.yaml        | 57 +++++++++++++++++++
 .../bindings/thermal/uniphier-thermal.txt          | 65 ----------------------
 2 files changed, 57 insertions(+), 65 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml
 delete mode 100644 Documentation/devicetree/bindings/thermal/uniphier-thermal.txt

Comments

Rob Herring April 28, 2020, 4:20 p.m. UTC | #1
On Thu, Apr 16, 2020 at 02:12:15PM +0900, Kunihiko Hayashi wrote:
> Convert the UniPhier thermal monitor binding to DT schema format.
> 
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
>  .../thermal/socionext,uniphier-thermal.yaml        | 57 +++++++++++++++++++
>  .../bindings/thermal/uniphier-thermal.txt          | 65 ----------------------
>  2 files changed, 57 insertions(+), 65 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml
>  delete mode 100644 Documentation/devicetree/bindings/thermal/uniphier-thermal.txt
> 
> diff --git a/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml b/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml
> new file mode 100644
> index 0000000..bdddc5b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml
> @@ -0,0 +1,57 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/thermal/socionext,uniphier-thermal.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Socionext UniPhier thermal monitor
> +
> +description: |
> +  This describes the devicetree bindings for thermal monitor supported by
> +  PVT(Process, Voltage and Temperature) monitoring unit implemented on
> +  Socionext UniPhier SoCs.
> +
> +maintainers:
> +  - Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - socionext,uniphier-pxs2-thermal
> +      - socionext,uniphier-ld20-thermal
> +      - socionext,uniphier-pxs3-thermal
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  "#thermal-sensor-cells":
> +    const: 0
> +
> +  socionext,tmod-calibration:
> +    $ref: /schemas/types.yaml#/definitions/uint32-array
> +    description:
> +      A pair of calibrated values referred from PVT, in case that the values
> +      aren't set on SoC, like a reference board.

So?:

maxItems: 2

> +
> +required:
> +  - compatible
> +  - interrupts
> +  - "#thermal-sensor-cells"
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    // The UniPhier thermal should be a subnode of a "syscon" compatible node.
> +
> +    sysctrl@61840000 {
> +        compatible = "socionext,uniphier-ld20-sysctrl",
> +                     "simple-mfd", "syscon";
> +        reg = <0x61840000 0x10000>;
> +
> +        pvtctl: thermal {
> +                compatible = "socionext,uniphier-ld20-thermal";
> +                interrupts = <0 3 1>;
> +                #thermal-sensor-cells = <0>;
> +        };
> +    };
Kunihiko Hayashi April 30, 2020, 3 a.m. UTC | #2
Hi Rob,

On 2020/04/29 1:20, Rob Herring wrote:
> On Thu, Apr 16, 2020 at 02:12:15PM +0900, Kunihiko Hayashi wrote:
>> Convert the UniPhier thermal monitor binding to DT schema format.
>>
>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>> ---
>>   .../thermal/socionext,uniphier-thermal.yaml        | 57 +++++++++++++++++++
>>   .../bindings/thermal/uniphier-thermal.txt          | 65 ----------------------
>>   2 files changed, 57 insertions(+), 65 deletions(-)
>>   create mode 100644 Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml
>>   delete mode 100644 Documentation/devicetree/bindings/thermal/uniphier-thermal.txt
>>
>> diff --git a/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml b/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml
>> new file mode 100644
>> index 0000000..bdddc5b
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml
>> @@ -0,0 +1,57 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/thermal/socionext,uniphier-thermal.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Socionext UniPhier thermal monitor
>> +
>> +description: |
>> +  This describes the devicetree bindings for thermal monitor supported by
>> +  PVT(Process, Voltage and Temperature) monitoring unit implemented on
>> +  Socionext UniPhier SoCs.
>> +
>> +maintainers:
>> +  - Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - socionext,uniphier-pxs2-thermal
>> +      - socionext,uniphier-ld20-thermal
>> +      - socionext,uniphier-pxs3-thermal
>> +
>> +  interrupts:
>> +    maxItems: 1
>> +
>> +  "#thermal-sensor-cells":
>> +    const: 0
>> +
>> +  socionext,tmod-calibration:
>> +    $ref: /schemas/types.yaml#/definitions/uint32-array
>> +    description:
>> +      A pair of calibrated values referred from PVT, in case that the values
>> +      aren't set on SoC, like a reference board.
> 
> So?:
> 
> maxItems: 2
Okay, I'll add that in v2.

Thank you,

---
Best Regards
Kunihiko Hayashi

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml b/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml
new file mode 100644
index 0000000..bdddc5b
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml
@@ -0,0 +1,57 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/thermal/socionext,uniphier-thermal.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Socionext UniPhier thermal monitor
+
+description: |
+  This describes the devicetree bindings for thermal monitor supported by
+  PVT(Process, Voltage and Temperature) monitoring unit implemented on
+  Socionext UniPhier SoCs.
+
+maintainers:
+  - Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
+
+properties:
+  compatible:
+    enum:
+      - socionext,uniphier-pxs2-thermal
+      - socionext,uniphier-ld20-thermal
+      - socionext,uniphier-pxs3-thermal
+
+  interrupts:
+    maxItems: 1
+
+  "#thermal-sensor-cells":
+    const: 0
+
+  socionext,tmod-calibration:
+    $ref: /schemas/types.yaml#/definitions/uint32-array
+    description:
+      A pair of calibrated values referred from PVT, in case that the values
+      aren't set on SoC, like a reference board.
+
+required:
+  - compatible
+  - interrupts
+  - "#thermal-sensor-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    // The UniPhier thermal should be a subnode of a "syscon" compatible node.
+
+    sysctrl@61840000 {
+        compatible = "socionext,uniphier-ld20-sysctrl",
+                     "simple-mfd", "syscon";
+        reg = <0x61840000 0x10000>;
+
+        pvtctl: thermal {
+                compatible = "socionext,uniphier-ld20-thermal";
+                interrupts = <0 3 1>;
+                #thermal-sensor-cells = <0>;
+        };
+    };
diff --git a/Documentation/devicetree/bindings/thermal/uniphier-thermal.txt b/Documentation/devicetree/bindings/thermal/uniphier-thermal.txt
deleted file mode 100644
index ceb92a9..0000000
--- a/Documentation/devicetree/bindings/thermal/uniphier-thermal.txt
+++ /dev/null
@@ -1,65 +0,0 @@ 
-* UniPhier Thermal bindings
-
-This describes the devicetree bindings for thermal monitor supported by
-PVT(Process, Voltage and Temperature) monitoring unit implemented on Socionext
-UniPhier SoCs.
-
-Required properties:
-- compatible :
-  - "socionext,uniphier-pxs2-thermal" : For UniPhier PXs2 SoC
-  - "socionext,uniphier-ld20-thermal" : For UniPhier LD20 SoC
-  - "socionext,uniphier-pxs3-thermal" : For UniPhier PXs3 SoC
-- interrupts : IRQ for the temperature alarm
-- #thermal-sensor-cells : Should be 0. See ./thermal.txt for details.
-
-Optional properties:
-- socionext,tmod-calibration: A pair of calibrated values referred from PVT,
-                              in case that the values aren't set on SoC,
-                              like a reference board.
-
-Example:
-
-	sysctrl@61840000 {
-		compatible = "socionext,uniphier-ld20-sysctrl",
-			     "simple-mfd", "syscon";
-		reg = <0x61840000 0x10000>;
-		...
-		pvtctl: pvtctl {
-			compatible = "socionext,uniphier-ld20-thermal";
-			interrupts = <0 3 1>;
-			#thermal-sensor-cells = <0>;
-		};
-		...
-	};
-
-	thermal-zones {
-		cpu_thermal {
-			polling-delay-passive = <250>;	/* 250ms */
-			polling-delay = <1000>;		/* 1000ms */
-			thermal-sensors = <&pvtctl>;
-
-			trips {
-				cpu_crit: cpu_crit {
-					temperature = <110000>;	/* 110C */
-					hysteresis = <2000>;
-					type = "critical";
-				};
-				cpu_alert: cpu_alert {
-					temperature = <100000>;	/* 100C */
-					hysteresis = <2000>;
-					type = "passive";
-				};
-			};
-
-			cooling-maps {
-				map0 {
-					trip = <&cpu_alert>;
-					cooling-device = <&cpu0 (-1) (-1)>;
-				};
-				map1 {
-					trip = <&cpu_alert>;
-					cooling-device = <&cpu2 (-1) (-1)>;
-				};
-			};
-		};
-	};