From: Douglas Anderson <dianders@chromium.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
rafael.j.wysocki@intel.com, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: mka@chromium.org, swboyd@chromium.org, mkshah@codeaurora.org,
evgreen@chromium.org, Douglas Anderson <dianders@chromium.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v4 2/5] soc: qcom: rpmh-rsc: We aren't notified of our own failure w/ NOTIFY_BAD
Date: Wed, 22 Apr 2020 14:55:00 -0700 [thread overview]
Message-ID: <20200422145408.v4.2.I1927d1bca2569a27b2d04986baf285027f0818a2@changeid> (raw)
In-Reply-To: <20200422145408.v4.1.Ic7096b3b9b7828cdd41cd5469a6dee5eb6abf549@changeid>
When a PM Notifier returns NOTIFY_BAD it doesn't get called with
CPU_PM_ENTER_FAILED. It only get called for CPU_PM_ENTER_FAILED if
someone else (further down the notifier chain) returns NOTIFY_BAD.
Handle this case by taking our CPU out of the list of ones that have
entered PM. Without this it's possible we could detect that the last
CPU went down (and we would flush) even if some CPU was alive. That's
not good since our flushing routines currently assume they're running
on the last CPU for mutual exclusion.
Fixes: 985427f997b6 ("soc: qcom: rpmh: Invoke rpmh_flush() for dirty caches")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
Changes in v4:
- ("...We aren't notified of our own failure...") split out for v4.
Changes in v3: None
Changes in v2: None
drivers/soc/qcom/rpmh-rsc.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c
index 3571a99fc839..e540e49fd61c 100644
--- a/drivers/soc/qcom/rpmh-rsc.c
+++ b/drivers/soc/qcom/rpmh-rsc.c
@@ -823,6 +823,10 @@ static int rpmh_rsc_cpu_pm_callback(struct notifier_block *nfb,
ret = NOTIFY_OK;
exit:
+ if (ret == NOTIFY_BAD)
+ /* We won't be called w/ CPU_PM_ENTER_FAILED */
+ cpumask_clear_cpu(smp_processor_id(), &drv->cpus_entered_pm);
+
spin_unlock(&drv->pm_lock);
return ret;
}
--
2.26.1.301.g55bc3eb7cb9-goog
next prev parent reply other threads:[~2020-04-22 21:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 21:54 [PATCH v4 1/5] soc: qcom: rpmh-rsc: Corrently ignore CPU_CLUSTER_PM notifications Douglas Anderson
2020-04-22 21:55 ` Douglas Anderson [this message]
2020-04-23 4:48 ` [PATCH v4 2/5] soc: qcom: rpmh-rsc: We aren't notified of our own failure w/ NOTIFY_BAD Maulik Shah
2020-04-24 2:38 ` Stephen Boyd
2020-04-24 2:41 ` Stephen Boyd
2020-04-22 21:55 ` [PATCH v4 3/5] kernel/cpu_pm: Fix uninitted local in cpu_pm Douglas Anderson
2020-04-24 2:43 ` Stephen Boyd
2020-04-22 21:55 ` [PATCH v4 4/5] soc: qcom: rpmh-rsc: Simplify locking by eliminating the per-TCS lock Douglas Anderson
2020-04-24 2:48 ` Stephen Boyd
2020-04-24 16:47 ` Doug Anderson
2020-04-22 21:55 ` [PATCH v4 5/5] soc: qcom: rpmh-rsc: Remove the pm_lock Douglas Anderson
2020-04-24 3:59 ` Stephen Boyd
2020-04-23 4:45 ` [PATCH v4 1/5] soc: qcom: rpmh-rsc: Corrently ignore CPU_CLUSTER_PM notifications Maulik Shah
2020-04-23 16:19 ` Doug Anderson
2020-04-24 2:38 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200422145408.v4.2.I1927d1bca2569a27b2d04986baf285027f0818a2@changeid \
--to=dianders@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=evgreen@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=mkshah@codeaurora.org \
--cc=rafael.j.wysocki@intel.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).