:ssb sprom.c: Fixed block comments coding style issues
diff mbox series

Message ID 20200424175043.16261-1-john.oldman@polehill.co.uk
State Accepted
Commit 2aad9f81d34c3ecb6b5dbfd7c64a76298d40c361
Headers show
Series
  • :ssb sprom.c: Fixed block comments coding style issues
Related show

Commit Message

John Oldman April 24, 2020, 5:50 p.m. UTC
Fixed coding style issues

Signed-off-by: John Oldman <john.oldman@polehill.co.uk>
---
 drivers/ssb/sprom.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

Comments

Michael Büsch April 24, 2020, 11:05 p.m. UTC | #1
On Fri, 24 Apr 2020 18:50:43 +0100
John Oldman <john.oldman@polehill.co.uk> wrote:

> Fixed coding style issues
> 
> Signed-off-by: John Oldman <john.oldman@polehill.co.uk>
> ---
>  drivers/ssb/sprom.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/ssb/sprom.c b/drivers/ssb/sprom.c
> index 52d2e0f33be7..42d620cee8a9 100644
> --- a/drivers/ssb/sprom.c
> +++ b/drivers/ssb/sprom.c
> @@ -78,7 +78,8 @@ ssize_t ssb_attr_sprom_show(struct ssb_bus *bus, char *buf,
>  
>  	/* Use interruptible locking, as the SPROM write might
>  	 * be holding the lock for several seconds. So allow userspace
> -	 * to cancel operation. */
> +	 * to cancel operation.
> +	 */
>  	err = -ERESTARTSYS;
>  	if (mutex_lock_interruptible(&bus->sprom_mutex))
>  		goto out_kfree;
> @@ -121,7 +122,8 @@ ssize_t ssb_attr_sprom_store(struct ssb_bus *bus,
>  
>  	/* Use interruptible locking, as the SPROM write might
>  	 * be holding the lock for several seconds. So allow userspace
> -	 * to cancel operation. */
> +	 * to cancel operation.
> +	 */
>  	err = -ERESTARTSYS;
>  	if (mutex_lock_interruptible(&bus->sprom_mutex))
>  		goto out_kfree;
> @@ -188,9 +190,11 @@ int ssb_fill_sprom_with_fallback(struct ssb_bus *bus, struct ssb_sprom *out)
>  bool ssb_is_sprom_available(struct ssb_bus *bus)
>  {
>  	/* status register only exists on chipcomon rev >= 11 and we need check
> -	   for >= 31 only */
> +	 * for >= 31 only
> +	 */
>  	/* this routine differs from specs as we do not access SPROM directly
> -	   on PCMCIA */
> +	 * on PCMCIA
> +	 */
>  	if (bus->bustype == SSB_BUSTYPE_PCI &&
>  	    bus->chipco.dev &&	/* can be unavailable! */
>  	    bus->chipco.dev->id.revision >= 31)


Acked-by: Michael Büsch <m@bues.ch>
Kalle Valo April 27, 2020, 5:26 a.m. UTC | #2
John Oldman <john.oldman@polehill.co.uk> writes:

> Fixed coding style issues
>
> Signed-off-by: John Oldman <john.oldman@polehill.co.uk>
> ---
>  drivers/ssb/sprom.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)

The title prefix should be "ssb: ", I'll fix it during commit.
Kalle Valo April 28, 2020, 9:01 a.m. UTC | #3
John Oldman <john.oldman@polehill.co.uk> wrote:

> Fixed coding style issues
> 
> Signed-off-by: John Oldman <john.oldman@polehill.co.uk>

Patch applied to wireless-drivers-next.git, thanks.

2aad9f81d34c ssb: sprom: fix block comments coding style issues

Patch
diff mbox series

diff --git a/drivers/ssb/sprom.c b/drivers/ssb/sprom.c
index 52d2e0f33be7..42d620cee8a9 100644
--- a/drivers/ssb/sprom.c
+++ b/drivers/ssb/sprom.c
@@ -78,7 +78,8 @@  ssize_t ssb_attr_sprom_show(struct ssb_bus *bus, char *buf,
 
 	/* Use interruptible locking, as the SPROM write might
 	 * be holding the lock for several seconds. So allow userspace
-	 * to cancel operation. */
+	 * to cancel operation.
+	 */
 	err = -ERESTARTSYS;
 	if (mutex_lock_interruptible(&bus->sprom_mutex))
 		goto out_kfree;
@@ -121,7 +122,8 @@  ssize_t ssb_attr_sprom_store(struct ssb_bus *bus,
 
 	/* Use interruptible locking, as the SPROM write might
 	 * be holding the lock for several seconds. So allow userspace
-	 * to cancel operation. */
+	 * to cancel operation.
+	 */
 	err = -ERESTARTSYS;
 	if (mutex_lock_interruptible(&bus->sprom_mutex))
 		goto out_kfree;
@@ -188,9 +190,11 @@  int ssb_fill_sprom_with_fallback(struct ssb_bus *bus, struct ssb_sprom *out)
 bool ssb_is_sprom_available(struct ssb_bus *bus)
 {
 	/* status register only exists on chipcomon rev >= 11 and we need check
-	   for >= 31 only */
+	 * for >= 31 only
+	 */
 	/* this routine differs from specs as we do not access SPROM directly
-	   on PCMCIA */
+	 * on PCMCIA
+	 */
 	if (bus->bustype == SSB_BUSTYPE_PCI &&
 	    bus->chipco.dev &&	/* can be unavailable! */
 	    bus->chipco.dev->id.revision >= 31)