linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dejin Zheng <zhengdejin5@gmail.com>
To: davem@davemloft.net, tglx@linutronix.de, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Dejin Zheng <zhengdejin5@gmail.com>
Subject: [PATCH net-next v1] ethernet: ks8842: delete unnecessary goto label
Date: Sat, 25 Apr 2020 19:56:12 +0800	[thread overview]
Message-ID: <20200425115612.17171-1-zhengdejin5@gmail.com> (raw)

the label of err_register is not necessary, so delete it to
simplify code.

Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
---
 drivers/net/ethernet/micrel/ks8842.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/micrel/ks8842.c b/drivers/net/ethernet/micrel/ks8842.c
index f3f6dfe3eddc..213ca33a9967 100644
--- a/drivers/net/ethernet/micrel/ks8842.c
+++ b/drivers/net/ethernet/micrel/ks8842.c
@@ -1204,7 +1204,7 @@ static int ks8842_probe(struct platform_device *pdev)
 	strcpy(netdev->name, "eth%d");
 	err = register_netdev(netdev);
 	if (err)
-		goto err_register;
+		goto err_get_irq;
 
 	platform_set_drvdata(pdev, netdev);
 
@@ -1213,7 +1213,6 @@ static int ks8842_probe(struct platform_device *pdev)
 
 	return 0;
 
-err_register:
 err_get_irq:
 	iounmap(adapter->hw_addr);
 err_ioremap:
-- 
2.25.0


             reply	other threads:[~2020-04-25 11:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-25 11:56 Dejin Zheng [this message]
2020-04-27 18:15 ` [PATCH net-next v1] ethernet: ks8842: delete unnecessary goto label David Miller
2020-04-28  2:58   ` Dejin Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200425115612.17171-1-zhengdejin5@gmail.com \
    --to=zhengdejin5@gmail.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).