[2/2] drivers: staging: rts5208: rtsx.c fix Unbalanced braces around else-if statements
diff mbox series

Message ID 20200427152442.26597-2-john.oldman@polehill.co.uk
State New, archived
Headers show
Series
  • [1/2] drivers: staging: rts5208: rtsx.c fix Unbalanced braces around else statement issue
Related show

Commit Message

John Oldman April 27, 2020, 3:24 p.m. UTC
Make a better job of fixing coding style issues, this time fixing
all blocks as per Joe Perches' comment.

Signed-off-by: John Oldman <john.oldman@polehill.co.uk>
---
 drivers/staging/rts5208/rtsx.c | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

Comments

Greg KH April 27, 2020, 4:04 p.m. UTC | #1
On Mon, Apr 27, 2020 at 04:24:42PM +0100, John Oldman wrote:
> Make a better job of fixing coding style issues, this time fixing
> all blocks as per Joe Perches' comment.
> 
> Signed-off-by: John Oldman <john.oldman@polehill.co.uk>
> ---
>  drivers/staging/rts5208/rtsx.c | 14 +++++---------
>  1 file changed, 5 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
> index ca836ca2ee81..e16a7b9c3203 100644
> --- a/drivers/staging/rts5208/rtsx.c
> +++ b/drivers/staging/rts5208/rtsx.c
> @@ -402,19 +402,15 @@ static int rtsx_control_thread(void *__dev)
>  		if (chip->srb->sc_data_direction == DMA_BIDIRECTIONAL) {
>  			dev_err(&dev->pci->dev, "UNKNOWN data direction\n");
>  			chip->srb->result = DID_ERROR << 16;
> -		}
> -
> -		/* reject if target != 0 or if LUN is higher than
> -		 * the maximum known LUN
> -		 */
> -		else if (chip->srb->device->id) {
> +		} else if (chip->srb->device->id) {
> +			/* reject if target != 0 or if LUN is higher than
> +			 * the maximum known LUN
> +			 */
>  			dev_err(&dev->pci->dev, "Bad target number (%d:%d)\n",
>  				chip->srb->device->id,
>  				(u8)chip->srb->device->lun);
>  			chip->srb->result = DID_BAD_TARGET << 16;
> -		}
> -
> -		else if (chip->srb->device->lun > chip->max_lun) {
> +		} else if (chip->srb->device->lun > chip->max_lun) {
>  			dev_err(&dev->pci->dev, "Bad LUN (%d:%d)\n",
>  				chip->srb->device->id,
>  				(u8)chip->srb->device->lun);
> -- 
> 2.17.1

Why is this not just one patch?
Joe Perches April 27, 2020, 5:14 p.m. UTC | #2
On Mon, 2020-04-27 at 18:04 +0200, Greg KH wrote:
> On Mon, Apr 27, 2020 at 04:24:42PM +0100, John Oldman wrote:
> > Make a better job of fixing coding style issues, this time fixing
> > all blocks as per Joe Perches' comment.
[]
> Why is this not just one patch?

Hi John.

These _should_ be one patch.

The subject line should be versioned and affirmative like:

Subject: [PATCH V2] staging: rts5208: rtsx: Use balanced braces for if/else if blocks

The subject should not include "fix", as this is a coding style
issue and not really a logical defect.

Lastly the "this time fixing" bit should be below the --- line.

cheers, Joe

Patch
diff mbox series

diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
index ca836ca2ee81..e16a7b9c3203 100644
--- a/drivers/staging/rts5208/rtsx.c
+++ b/drivers/staging/rts5208/rtsx.c
@@ -402,19 +402,15 @@  static int rtsx_control_thread(void *__dev)
 		if (chip->srb->sc_data_direction == DMA_BIDIRECTIONAL) {
 			dev_err(&dev->pci->dev, "UNKNOWN data direction\n");
 			chip->srb->result = DID_ERROR << 16;
-		}
-
-		/* reject if target != 0 or if LUN is higher than
-		 * the maximum known LUN
-		 */
-		else if (chip->srb->device->id) {
+		} else if (chip->srb->device->id) {
+			/* reject if target != 0 or if LUN is higher than
+			 * the maximum known LUN
+			 */
 			dev_err(&dev->pci->dev, "Bad target number (%d:%d)\n",
 				chip->srb->device->id,
 				(u8)chip->srb->device->lun);
 			chip->srb->result = DID_BAD_TARGET << 16;
-		}
-
-		else if (chip->srb->device->lun > chip->max_lun) {
+		} else if (chip->srb->device->lun > chip->max_lun) {
 			dev_err(&dev->pci->dev, "Bad LUN (%d:%d)\n",
 				chip->srb->device->id,
 				(u8)chip->srb->device->lun);