From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Marek Vasut <marex@denx.de>,
David Jander <david@protonic.nl>,
devicetree@vger.kernel.org
Subject: [PATCH v1] dt-bindings: net: nxp,tja11xx: rework validation support
Date: Tue, 5 May 2020 12:42:15 +0200 [thread overview]
Message-ID: <20200505104215.8975-1-o.rempel@pengutronix.de> (raw)
To properly identify this node, we need to use ethernet-phy-id0180.dc80.
And add missing required properties.
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
.../devicetree/bindings/net/nxp,tja11xx.yaml | 55 ++++++++++++-------
1 file changed, 35 insertions(+), 20 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/nxp,tja11xx.yaml b/Documentation/devicetree/bindings/net/nxp,tja11xx.yaml
index 42be0255512b3..cc322107a24a2 100644
--- a/Documentation/devicetree/bindings/net/nxp,tja11xx.yaml
+++ b/Documentation/devicetree/bindings/net/nxp,tja11xx.yaml
@@ -1,4 +1,4 @@
-# SPDX-License-Identifier: GPL-2.0+
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
%YAML 1.2
---
$id: http://devicetree.org/schemas/net/nxp,tja11xx.yaml#
@@ -12,44 +12,59 @@ maintainers:
- Heiner Kallweit <hkallweit1@gmail.com>
description:
- Bindings for NXP TJA11xx automotive PHYs
+ Bindings for the NXP TJA1102 automotive PHY. This is a dual PHY package where
+ only the first PHY has global configuration register and HW health
+ monitoring.
-allOf:
- - $ref: ethernet-phy.yaml#
+properties:
+ compatible:
+ const: ethernet-phy-id0180.dc80
+ description: ethernet-phy-id0180.dc80 used for TJA1102 PHY
+
+ reg:
+ minimum: 0
+ maximum: 14
+ description:
+ The PHY address of the parent PHY.
+
+ '#address-cells':
+ description: number of address cells for the MDIO bus
+ const: 1
+
+ '#size-cells':
+ description: number of size cells on the MDIO bus
+ const: 0
patternProperties:
- "^ethernet-phy@[0-9a-f]+$":
+ "^ethernet-phy@[0-9a-f]$":
type: object
- description: |
- Some packages have multiple PHYs. Secondary PHY should be defines as
- subnode of the first (parent) PHY.
+ description:
+ Integrated PHY node
properties:
reg:
- minimum: 0
- maximum: 31
+ minimum: 1
+ maximum: 15
description:
- The ID number for the child PHY. Should be +1 of parent PHY.
+ The PHY address of the slave PHY. Should be +1 of parent PHY.
required:
- reg
-examples:
- - |
- mdio {
- #address-cells = <1>;
- #size-cells = <0>;
+required:
+ - compatible
+ - reg
+ - '#address-cells'
+ - '#size-cells'
- tja1101_phy0: ethernet-phy@4 {
- reg = <0x4>;
- };
- };
+examples:
- |
mdio {
#address-cells = <1>;
#size-cells = <0>;
tja1102_phy0: ethernet-phy@4 {
+ compatible = "ethernet-phy-id0180.dc80";
reg = <0x4>;
#address-cells = <1>;
#size-cells = <0>;
--
2.26.2
next reply other threads:[~2020-05-05 10:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 10:42 Oleksij Rempel [this message]
2020-05-05 14:01 ` [PATCH v1] dt-bindings: net: nxp,tja11xx: rework validation support Andrew Lunn
2020-05-06 5:11 ` Oleksij Rempel
2020-05-06 15:07 ` Andrew Lunn
2020-05-13 2:34 ` Rob Herring
2020-05-13 2:36 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200505104215.8975-1-o.rempel@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=david@protonic.nl \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).