From: Alexandru Ardelean <alexandru.ardelean@analog.com>
To: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <jic23@kernel.org>, Alexandru Ardelean <alexandru.ardelean@analog.com>
Subject: [PATCH 2/3] iio: core: simplify alloc alignment code
Date: Fri, 8 May 2020 17:13:05 +0300 [thread overview]
Message-ID: <20200508141306.17222-2-alexandru.ardelean@analog.com> (raw)
In-Reply-To: <20200508141306.17222-1-alexandru.ardelean@analog.com>
There was a recent discussion about this code:
https://lore.kernel.org/linux-iio/20200322165317.0b1f0674@archlinux/
This looks like a good time to rework this, since any issues about it
should pop-up under testing, because the iio_dev is having a bit of an
overhaul and stuff being moved to iio_dev_priv.
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
---
drivers/iio/industrialio-core.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
index f0888dd84d3d..b924197b5984 100644
--- a/drivers/iio/industrialio-core.c
+++ b/drivers/iio/industrialio-core.c
@@ -1521,13 +1521,9 @@ struct iio_dev *iio_device_alloc(int sizeof_priv)
struct iio_dev *dev;
size_t alloc_size;
- alloc_size = sizeof(struct iio_dev_priv);
- if (sizeof_priv) {
- alloc_size = ALIGN(alloc_size, IIO_ALIGN);
- alloc_size += sizeof_priv;
- }
- /* ensure 32-byte alignment of whole construct ? */
- alloc_size += IIO_ALIGN - 1;
+ alloc_size = ALIGN(sizeof(struct iio_dev_priv), IIO_ALIGN);
+ if (sizeof_priv)
+ alloc_size += ALIGN(sizeof_priv, IIO_ALIGN);
iio_dev_priv = kzalloc(alloc_size, GFP_KERNEL);
if (!iio_dev_priv)
--
2.17.1
next prev parent reply other threads:[~2020-05-08 14:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 14:13 [PATCH 1/3] iio: core: wrap IIO device into a iio_dev_priv object Alexandru Ardelean
2020-05-08 14:13 ` Alexandru Ardelean [this message]
2020-05-08 14:13 ` [PATCH 3/3] iio: core: move debugfs data on the private iio dev info Alexandru Ardelean
2020-05-08 15:40 ` [PATCH 1/3] iio: core: wrap IIO device into a iio_dev_priv object Jonathan Cameron
2020-05-08 15:44 ` Jonathan Cameron
2020-05-11 9:16 ` Ardelean, Alexandru
2020-05-11 17:42 ` Jonathan Cameron
2020-05-12 11:26 ` Ardelean, Alexandru
2020-05-16 16:29 ` Jonathan Cameron
2020-05-18 8:07 ` Ardelean, Alexandru
2020-05-21 18:00 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200508141306.17222-2-alexandru.ardelean@analog.com \
--to=alexandru.ardelean@analog.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).