From: Kees Cook <keescook@chromium.org>
To: WeiXiong Liao <liaoweixiong@allwinnertech.com>
Cc: Kees Cook <keescook@chromium.org>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
Jonathan Corbet <corbet@lwn.net>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Rob Herring <robh@kernel.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org
Subject: [PATCH v8 11/11] pstore/blk: Introduce "best_effort" mode
Date: Mon, 11 May 2020 16:32:29 -0700 [thread overview]
Message-ID: <20200511233229.27745-12-keescook@chromium.org> (raw)
In-Reply-To: <20200511233229.27745-1-keescook@chromium.org>
In order to use arbitrary block devices as a pstore backend, provide a
new module param named "best_effort", which will allow using any block
device, even if it has not provided a panic_write callback.
Signed-off-by: Kees Cook <keescook@chromium.org>
---
fs/pstore/blk.c | 21 ++++++++++++++++++++-
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/fs/pstore/blk.c b/fs/pstore/blk.c
index a1bd7c1fdfa0..9000d2e9f1c5 100644
--- a/fs/pstore/blk.c
+++ b/fs/pstore/blk.c
@@ -51,6 +51,10 @@ static long ftrace_size = -1;
module_param(ftrace_size, long, 0400);
MODULE_PARM_DESC(ftrace_size, "ftrace size in kbytes");
+static bool best_effort;
+module_param(best_effort, bool, 0400);
+MODULE_PARM_DESC(best_effort, "use best effort to write (i.e. do not require storage driver pstore support, default: off)");
+
/*
* blkdev - the block device to use for pstore storage
*
@@ -378,7 +382,8 @@ static int __register_pstore_blk(struct pstore_blk_info *info)
}
/* only allow driver matching the @blkdev */
- if (!binfo.devt || MAJOR(binfo.devt) != info->major) {
+ if (!binfo.devt || (!best_effort &&
+ MAJOR(binfo.devt) != info->major)) {
pr_debug("invalid major %u (expect %u)\n",
info->major, MAJOR(binfo.devt));
ret = -ENODEV;
@@ -480,6 +485,20 @@ int pstore_blk_get_config(struct pstore_blk_config *info)
}
EXPORT_SYMBOL_GPL(pstore_blk_get_config);
+static int __init pstore_blk_init(void)
+{
+ struct pstore_blk_info info = { };
+ int ret = 0;
+
+ mutex_lock(&pstore_blk_lock);
+ if (!pstore_zone_info && best_effort && blkdev[0])
+ ret = __register_pstore_blk(&info);
+ mutex_unlock(&pstore_blk_lock);
+
+ return ret;
+}
+late_initcall(pstore_blk_init);
+
static void __exit pstore_blk_exit(void)
{
mutex_lock(&pstore_blk_lock);
--
2.20.1
prev parent reply other threads:[~2020-05-11 23:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 23:32 [PATCH v8 00/11] pstore: mtd: support crash log to block and mtd device Kees Cook
2020-05-11 23:32 ` [PATCH v8 01/11] pstore/zone: Introduce common layer to manage storage zones Kees Cook
2020-05-12 3:55 ` WeiXiong Liao
2020-05-12 5:15 ` Kees Cook
2020-05-12 5:47 ` WeiXiong Liao
2020-05-11 23:32 ` [PATCH v8 02/11] pstore/blk: Introduce backend for block devices Kees Cook
2020-05-11 23:32 ` [PATCH v8 03/11] pstore/zone,blk: Add support for pmsg frontend Kees Cook
2020-05-11 23:32 ` [PATCH v8 04/11] pstore/zone,blk: Add console frontend support Kees Cook
2020-05-11 23:32 ` [PATCH v8 05/11] pstore/zone,blk: Add ftrace " Kees Cook
2020-05-11 23:32 ` [PATCH v8 06/11] Documentation: Add details for pstore/blk Kees Cook
2020-05-11 23:32 ` [PATCH v8 07/11] pstore/zone: Provide way to skip "broken" zone for MTD devices Kees Cook
2020-05-11 23:32 ` [PATCH v8 08/11] pstore/blk: Provide way to query pstore configuration Kees Cook
2020-05-11 23:32 ` [PATCH v8 09/11] pstore/blk: Support non-block storage devices Kees Cook
2020-05-11 23:32 ` [PATCH v8 10/11] mtd: Support kmsg dumper based on pstore/blk Kees Cook
2020-05-12 3:12 ` WeiXiong Liao
2020-05-12 5:12 ` Kees Cook
2020-05-12 5:56 ` WeiXiong Liao
2020-05-11 23:32 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200511233229.27745-12-keescook@chromium.org \
--to=keescook@chromium.org \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=corbet@lwn.net \
--cc=liaoweixiong@allwinnertech.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=tony.luck@intel.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).